You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/29 19:38:07 UTC

[jira] [Commented] (LANG-1122) Inconsistent behavior of swap for malformed inputs

    [ https://issues.apache.org/jira/browse/LANG-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519794#comment-14519794 ] 

ASF GitHub Bot commented on LANG-1122:
--------------------------------------

Github user britter commented on the pull request:

    https://github.com/apache/commons-lang/pull/47#issuecomment-97514318
  
    Hello @beradrian,
    
    sorry for being so oblivious. Yes it would be best to create a separate PR for this issue. I've already created a new jira issue for tracking this: https://issues.apache.org/jira/browse/LANG-1122


> Inconsistent behavior of swap for malformed inputs
> --------------------------------------------------
>
>                 Key: LANG-1122
>                 URL: https://issues.apache.org/jira/browse/LANG-1122
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Benedikt Ritter
>             Fix For: Patch Needed, 3.5
>
>
> Following the discussion at https://github.com/apache/commons-lang/pull/47 we need to decide how malformed inputs should be handled by the swap method. We have to handle several forms of malformed inputs and we should decide how to do that based on the current behavior of ArrayUtils. Malformed inputs are:
> * array == null
> * array.length == 0
> * start < 0
> * end < 0
> * offset < 0
> * start > end
> * start > array.length
> * end > array.length
> * start + offset > array.length
> * end + offset > array.length



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)