[GitHub] johnyangk commented on a change in pull request #99: [NEMO-64] Fix map stage hang under DataSkewPolicy

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #99: [NEMO-64] Fix map stage hang under DataSkewPolicy
URL: https://github.com/apache/incubator-nemo/pull/99#discussion_r209152943
 
 

 ##########
 File path: runtime/executor/src/test/java/edu/snu/nemo/runtime/executor/datatransfer/DataTransferTest.java
 ##########
 @@ -300,6 +303,15 @@ private void writeAndRead(final BlockManagerWorker sender,
     dummyIREdge.setProperty(DataPersistenceProperty.of(DataPersistenceProperty.Value.Keep));
     dummyIREdge.setProperty(EncoderProperty.of(ENCODER_FACTORY));
     dummyIREdge.setProperty(DecoderProperty.of(DECODER_FACTORY));
+    if (dummyIREdge.getPropertyValue(CommunicationPatternProperty.class).get()
 
 Review comment:
   I'm not sure the `DataSkewMetricProperty` set in L306-L314, L398-L405 is used/checked afterwards. A standalone test may be a better option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services