[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #6695: [Relay] Change some passes to mix mode

[GitBox <gi...@apache.org>]

mbrookhart commented on a change in pull request #6695:
URL: https://github.com/apache/incubator-tvm/pull/6695#discussion_r506527342



##########
File path: src/relay/transforms/fold_constant.cc
##########
@@ -118,7 +120,7 @@ class ConstantFolder : public ExprMutator {
     }
   }
 
-  Expr VisitExpr_(const CallNode* call) final {
+  Expr Rewrite_(const CallNode* call, const Expr& post) final {

Review comment:
       (nitpick) You could locally rename this argument from post to res, and then you wouldn't need most of the other changes in the function?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org