You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by mikert <gi...@git.apache.org> on 2014/12/14 13:59:35 UTC

[GitHub] storm pull request: Added support for serialization to SequenceFil...

GitHub user mikert opened a pull request:

    https://github.com/apache/storm/pull/347

    Added support for serialization to SequenceFileBolt

    Added support for org.apache.hadoop.io.serializer.Serialization to the
    SequenceFileBolt. The new SerializableSequenceFormat interface allows
    serialization systems like Avro to be plugged into the SequenceFileBolt.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikert/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #347
    
----
commit 569b0082e4d657d67737d6a7bf851ad0fcb057f3
Author: Mike Thomsen <mi...@gmail.com>
Date:   2014-12-14T12:54:59Z

    Added support for serialization to SequenceFileBolt
    
    Added support for org.apache.hadoop.io.serializer.Serialization to the
    SequenceFileBolt. The new SerializableSequenceFormat interface allows
    serialization systems like Avro to be plugged into the SequenceFileBolt.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Added support for serialization to SequenceFil...

Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/storm/pull/347#discussion_r21839632
  
    --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/SequenceFileBolt.java ---
    @@ -108,7 +109,11 @@ public void execute(Tuple tuple) {
             try {
                 long offset;
                 synchronized (this.writeLock) {
    -                this.writer.append(this.format.key(tuple), this.format.value(tuple));
    +                if (this.format instanceof SerializableSequenceFormat) {
    --- End diff --
    
    The new interface and type checking is only necessary for backwards compatibility, you could change the return type of original SequenceFormat interface to Object and no other code change will be necessary . I would add that as a comment here so when we decide to do a major version bump we could get rid of this extra code and the extra interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Added support for serialization to SequenceFil...

Posted by mikert <gi...@git.apache.org>.
GitHub user mikert reopened a pull request:

    https://github.com/apache/storm/pull/347

    Added support for serialization to SequenceFileBolt

    Added support for org.apache.hadoop.io.serializer.Serialization to the
    SequenceFileBolt. The new SerializableSequenceFormat interface allows
    serialization systems like Avro to be plugged into the SequenceFileBolt.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikert/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #347
    
----
commit 569b0082e4d657d67737d6a7bf851ad0fcb057f3
Author: Mike Thomsen <mi...@gmail.com>
Date:   2014-12-14T12:54:59Z

    Added support for serialization to SequenceFileBolt
    
    Added support for org.apache.hadoop.io.serializer.Serialization to the
    SequenceFileBolt. The new SerializableSequenceFormat interface allows
    serialization systems like Avro to be plugged into the SequenceFileBolt.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-595 Added support for serialization to S...

Posted by mikert <gi...@git.apache.org>.
Github user mikert commented on the pull request:

    https://github.com/apache/storm/pull/347#issuecomment-67142387
  
    Created a Jira ticket and updated the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-595 Added support for serialization to S...

Posted by mikert <gi...@git.apache.org>.
Github user mikert closed the pull request at:

    https://github.com/apache/storm/pull/347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Added support for serialization to SequenceFil...

Posted by mikert <gi...@git.apache.org>.
Github user mikert closed the pull request at:

    https://github.com/apache/storm/pull/347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-595 Added support for serialization to S...

Posted by mikert <gi...@git.apache.org>.
Github user mikert commented on the pull request:

    https://github.com/apache/storm/pull/347#issuecomment-67368239
  
    I'm going to close this down and redo it according to the feedback from here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Added support for serialization to SequenceFil...

Posted by mikert <gi...@git.apache.org>.
Github user mikert commented on the pull request:

    https://github.com/apache/storm/pull/347#issuecomment-67100672
  
    @harshach Sure thing. Can you provide feedback about Parth-Brahmbhatt's comment? I did it that way to ensure that code written for 0.9.3 wouldn't be immediately broken in 0.10.0. However, I can easily make the change since it probably would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Added support for serialization to SequenceFil...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/347#issuecomment-67024196
  
    @mikert  Could you please open a JIRA for this. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---