You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Timothy Chen <tn...@apache.org> on 2014/03/26 18:55:54 UTC
Review Request 19690: Patch for KAFKA-1341
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19690/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1341
https://issues.apache.org/jira/browse/KAFKA-1341
Repository: kafka
Description
-------
Fix selector connection id checking
Diffs
-----
clients/src/main/java/org/apache/kafka/common/network/Selector.java 983963200ce81614577cd6182a5d2f10c22b95d4
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 90e2dcf5434db546387302fb0219edfdb363592e
Diff: https://reviews.apache.org/r/19690/diff/
Testing
-------
Thanks,
Timothy Chen
Re: Review Request 19690: Patch for KAFKA-1341
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19690/
-----------------------------------------------------------
(Updated March 31, 2014, 9:44 p.m.)
Review request for kafka.
Bugs: KAFKA-1341
https://issues.apache.org/jira/browse/KAFKA-1341
Repository: kafka
Description (updated)
-------
KAFKA-1341 Client Selector doesn't check connection id properly
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/network/Selector.java 5d93965a33bedc471fe6126277992591e0560add
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 99856e93f307e5e3db045653355bfb0d19114a0d
Diff: https://reviews.apache.org/r/19690/diff/
Testing
-------
Thanks,
Timothy Chen
Re: Review Request 19690: Patch for KAFKA-1341
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19690/
-----------------------------------------------------------
(Updated March 31, 2014, 9:42 p.m.)
Review request for kafka.
Bugs: KAFKA-1341
https://issues.apache.org/jira/browse/KAFKA-1341
Repository: kafka
Description (updated)
-------
KAFKA-1341 Client Selector doesn't check connection id properly
KAFKA-1323 Fix log directory to support relative directories
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/network/Selector.java 5d93965a33bedc471fe6126277992591e0560add
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 99856e93f307e5e3db045653355bfb0d19114a0d
core/src/main/scala/kafka/cluster/Partition.scala 0b88f14c4855b27242906cd45930bae501e26226
core/src/main/scala/kafka/server/ReplicaManager.scala 255be063ee247a849e527297c987da4625d749ca
core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa
Diff: https://reviews.apache.org/r/19690/diff/
Testing
-------
Thanks,
Timothy Chen
Re: Review Request 19690: Patch for KAFKA-1341
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19690/#review38723
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On March 26, 2014, 5:55 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19690/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 5:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1341
> https://issues.apache.org/jira/browse/KAFKA-1341
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Fix selector connection id checking
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/network/Selector.java 983963200ce81614577cd6182a5d2f10c22b95d4
> clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 90e2dcf5434db546387302fb0219edfdb363592e
>
> Diff: https://reviews.apache.org/r/19690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>