You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2015/05/16 10:35:03 UTC

[Issue 126312] New: Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

https://bz.apache.org/ooo/show_bug.cgi?id=126312

          Issue ID: 126312
        Issue Type: DEFECT
           Summary: Window authentication (NTLM) in WebDAV doesn't work:
                    need serf upgrade
           Product: General
           Version: 4.1.1
          Hardware: All
                OS: Windows, all
            Status: CONFIRMED
          Severity: normal
          Priority: P5
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: giuseppe.castagno@acca-esse.eu

While implementing my solution to issue 126305 I came across the problem on
issue subject.

Step to reproduce:

1) have 2 Windows 7 Professional PCs;
2) on one of them (PC A) activate IIS;
3) on this PC activate WebDAV on the IIS, disable the Anonymous authentication,
enable the Basic authentication only;
4) on this PC enable the Web service on Firewall as well;
5) on the other PC install AOO 4.1.1, be it PC B;
6) first try to access PC A from PC B using a web browser, available at
http://<ip address PC A> the default web page should be displayed;
7) in case you need to see the http exchange, install on one of the PC
WireShark as well;
8) now from PC B try to access PC A WebDAV, by typing http://<ip address> on
open dialog box
9) AOO will ask for user name and password and the default html page on PC A
will appear
10) now on PC A disable Basic authentication and enable the Windows one leaving
it as the only one
11) redo the test in 8) this time AOO will display the error:

Error reading data from the Internet.
Server error message.

This happens because serf 1.2.1 does not support the Windows authentication.
>From serf 1.3.8 [1] changelog, the first serv vers. to support it is 1.3.0.
>From ver. 1.3.0 on serf devs changed the build system, moving to SCons [2].
This means the way serf is build in AOO needs to be changed as well.

I tried in Linux and I think I succeeded, but so far my effort on Windows I get
nil result.

It should be kept in mind that serf will migrate from the current repo hosting,
see this forum exchange [3] for the discussion on the topic.

[1] https://code.google.com/p/serf
[2] http://www.scons.org
[3] https://groups.google.com/forum/#!topic/serf-dev/razFVsSxMgQ

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.2.0
              Flags|4.1.2_release_blocker?      |4.1.2_release_blocker-

--- Comment #6 from Andrea Pescetti <pe...@apache.org> ---
As discussed in the issue, this one will not be included in 4.1.2 since it
requires build adaptations and it doesn't work on MacOS. Moreover, the
essential functionality is already provided by the other two patches in this
series (now included both in trunk and AOO410).

This one can be committed to trunk once it is complete; or it might be
superseded by future serf (now Apache Serf) updates.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |PATCH
                 CC|                            |mseidel@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #5 from Andrea Pescetti <pe...@apache.org> ---
Just for better understanding: seeing the combined effect of the three patches,
what does one miss if we don't include this one (the third one, i.e., the Serf
update) in OpenOffice 4.1.2? I mean, are the first and second patch enough for
addressing the main use case?

-- 
You are receiving this mail because:
You are the assignee for the issue.

4.1.2_release_blocker denied: [Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
Andrea Pescetti <pe...@apache.org> has denied Andrea Pescetti
<pe...@apache.org>'s request for 4.1.2_release_blocker:
Issue 126312: Window authentication (NTLM) in WebDAV doesn't work: need serf
upgrade
https://bz.apache.org/ooo/show_bug.cgi?id=126312



--- Comment #6 from Andrea Pescetti <pe...@apache.org> ---
As discussed in the issue, this one will not be included in 4.1.2 since it
requires build adaptations and it doesn't work on MacOS. Moreover, the
essential functionality is already provided by the other two patches in this
series (now included both in trunk and AOO410).

This one can be committed to trunk once it is complete; or it might be
superseded by future serf (now Apache Serf) updates.

review requested: [Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade : [Attachment 84823] Proposed patch to fix the issue, version #1

Posted by bu...@apache.org.
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> has asked 
for review:
Issue 126312: Window authentication (NTLM) in WebDAV doesn't work: need serf
upgrade
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Attachment 84823: Proposed patch to fix the issue, version #1
https://bz.apache.org/ooo/attachment.cgi?id=84823&action=edit



--- Comment #1 from Giuseppe Castagno (aka beppec56)
<gi...@acca-esse.eu> ---
Created attachment 84823
  --> https://bz.apache.org/ooo/attachment.cgi?id=84823&action=edit
Proposed patch to fix the issue, version #1

A note about the upgrade.

On the Windows porting.
In order to figure out what changes I needed to be able to rewrite the
makefile,
I built serf natively with scons, taking note of the needed Windows libraries
and
source files.

On the Linux porting.
I used the SCons build system, since IMHO it's the best way to do it, when it's
possible natively.
The linked library seems ok, but need be checked if ok in a production build
system.

On the other platform porting.
I couldn't do anything, not having the build systems needed.
Briefly, if there is availability of python natively, and the build is native,
just install python (min vers is 2.7) and install SCons (min ver is 2.3.0)
and it should work.

To test it
in Windows:
- you need to test WebDAV on a server with only the Windows authorization
available, in order to test it thoroughly.
The NTLM authorization mode will work only on Windows platform, since serf uses
Windows API to build the credential.

Things still to be checked:

in Windows Platform.
Check what happens when the Windows user of the PC is different form the user
on WebDAV.

in all platforms:
- need to check a https WebDAV server, to see if certificates are properly
managed

in Linux:
- try if the serf logging facility works (special debugging build, not meant
for production).
I didn't have time to test it.

in other platforms:
- need to check the porting, if it works.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

damjan@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damjan@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84823|                            |review?
              Flags|                            |

--- Comment #1 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Created attachment 84823
  --> https://bz.apache.org/ooo/attachment.cgi?id=84823&action=edit
Proposed patch to fix the issue, version #1

A note about the upgrade.

On the Windows porting.
In order to figure out what changes I needed to be able to rewrite the
makefile,
I built serf natively with scons, taking note of the needed Windows libraries
and
source files.

On the Linux porting.
I used the SCons build system, since IMHO it's the best way to do it, when it's
possible natively.
The linked library seems ok, but need be checked if ok in a production build
system.

On the other platform porting.
I couldn't do anything, not having the build systems needed.
Briefly, if there is availability of python natively, and the build is native,
just install python (min vers is 2.7) and install SCons (min ver is 2.3.0)
and it should work.

To test it
in Windows:
- you need to test WebDAV on a server with only the Windows authorization
available, in order to test it thoroughly.
The NTLM authorization mode will work only on Windows platform, since serf uses
Windows API to build the credential.

Things still to be checked:

in Windows Platform.
Check what happens when the Windows user of the PC is different form the user
on WebDAV.

in all platforms:
- need to check a https WebDAV server, to see if certificates are properly
managed

in Linux:
- try if the serf logging facility works (special debugging build, not meant
for production).
I didn't have time to test it.

in other platforms:
- need to check the porting, if it works.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Tassoman <ta...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tassoman@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #2 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
I tested a little more the patch:

- I tried to access a WebDAV server on which the user was different from the
one running AOO: the credential dialog was not shown instead a server error was
reported, hence there is still some work to do to implement this new user
interface dialog;

- randomly, when you close AOO, there is a problem of access violation in one
of the Windows core library, I suspect this happens while freeing the memory
when shutting down the application.
This happens only if during the session you access a WebDAV server on which the
Windows authorization is used.

Unfortunately to understand what happens in both I need to debug using a
Microsoft tool, and at the moment I'm not able to.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #10 from Matthias Seidel <ms...@apache.org> ---
I doubt that it works with this Test version.

Serf is still at 1.21. NTLM authentication was introduced in 1.30:
https://serf.apache.org/abi/changelog/serf/1.3.0/log.html

We would need a build from the serf branch to test.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Peter <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |petko@apache.org

--- Comment #9 from Peter <pe...@apache.org> ---
Hi, Can more people please test if this is still the case with Test Version:
https://home.apache.org/~mseidel/AOO-builds/AOO-4112-Test/

If you need advice how to install next to the productive version please give a
hint.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #4 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
@Andrea:
this patch needs checking, it will build on Linux and on Windows but not on
Mac.

Needs discussion with a developer about what to do about it, along with the
need to verify the build on Linux where I used SCons. Probably this needs
tweaking too.

Besides serf is being moved to ASF, better wait for serf 1.4.0 IMHO.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Kay <ks...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kschenk@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #13 from damjan@apache.org ---
We use Curl instead of Serf now for WebDAV, is this bug still relevant?

-- 
You are receiving this mail because:
You are the assignee for the issue.

4.1.2_release_blocker requested: [Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
Andrea Pescetti <pe...@apache.org> has asked  for 4.1.2_release_blocker:
Issue 126312: Window authentication (NTLM) in WebDAV doesn't work: need serf
upgrade
https://bz.apache.org/ooo/show_bug.cgi?id=126312



--- Comment #3 from Andrea Pescetti <pe...@apache.org> ---
Nominating as blocker for OpenOffice 4.1.2. This is the third patch in a set of
three patches that, combined, solve a major interoperability (Sharepoint) bug.

For reference:
First patch   https://bz.apache.org/ooo/show_bug.cgi?id=125194
Second patch  https://bz.apache.org/ooo/show_bug.cgi?id=126305

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

John Dougrez-Lewis <jl...@lightblue.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jlewis@lightblue.com

--- Comment #7 from John Dougrez-Lewis <jl...@lightblue.com> ---
Hello,

Just for the record:

I encountered the same problem descibed above.

I raised a query here:
https://forum.openoffice.org/en/forum/viewtopic.php?f=6&t=81481

After subsequently finding this bug report, I can confirm that, after building
version 1.3.8 of serf.dll under Windows and just replacing it in my current OOO
1.4.2 install, I was able to open WebDAV-hosted files, which I was unable to do
with the previous serf.dll version.

Regards,

John

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pescetti@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #12 from Arrigo Marchiori <ar...@yahoo.it> ---
Sorry for the "broken" link! Here it is:

https://home.apache.org/~ardovm/openoffice/windows/Apache_OpenOffice-2021-12-06_Win_x86_install_en-US.exe

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Arrigo Marchiori <ar...@yahoo.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ardovm@yahoo.it

--- Comment #11 from Arrigo Marchiori <ar...@yahoo.it> ---
(In reply to Matthias Seidel from comment #10)
> I doubt that it works with this Test version.
> 
> Serf is still at 1.21. NTLM authentication was introduced in 1.30:
> https://serf.apache.org/abi/changelog/serf/1.3.0/log.html
> 
> We would need a build from the serf branch to test.

Please try this one:
https://home.apache.org/~ardovm/openoffice/windows/Apache_OpenOffice-2021-12-
06_Win_x86_install_en-US.exe

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |4.1.2_release_blocker?
   Target Milestone|---                         |4.1.2

--- Comment #3 from Andrea Pescetti <pe...@apache.org> ---
Nominating as blocker for OpenOffice 4.1.2. This is the third patch in a set of
three patches that, combined, solve a major interoperability (Sharepoint) bug.

For reference:
First patch   https://bz.apache.org/ooo/show_bug.cgi?id=125194
Second patch  https://bz.apache.org/ooo/show_bug.cgi?id=126305

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 126312] Window authentication (NTLM) in WebDAV doesn't work: need serf upgrade

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126312

--- Comment #8 from John Dougrez-Lewis <jl...@lightblue.com> ---
4.1.2 not 1.4.2 !

-- 
You are receiving this mail because:
You are the assignee for the issue.