You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/11/25 23:28:51 UTC

Review Request 15845: Fixed a flaky test Fixed ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15845/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.

- This patch can be committed first and I will address AWAIT_READY change subsequently.


Diffs
-----

  src/tests/master_contender_detector_tests.cpp 5e4237454133edc155e74ffa04aec24ccd04c1b4 

Diff: https://reviews.apache.org/r/15845/diff/


Testing
-------

make check Linux (100 iterations) and OSX.


Thanks,

Jiang Yan Xu


Re: Review Request 15845: Fixed a flaky test Fixed ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork

Posted by Ben Mahler <be...@gmail.com>.

> On Nov. 25, 2013, 10:34 p.m., Ben Mahler wrote:
> > Ship It!

This is now submitted.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15845/#review29401
-----------------------------------------------------------


On Nov. 25, 2013, 10:30 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15845/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-823
>     https://issues.apache.org/jira/browse/MESOS-823
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> - This patch can be committed first and I will address AWAIT_READY change subsequently.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_contender_detector_tests.cpp 5e4237454133edc155e74ffa04aec24ccd04c1b4 
> 
> Diff: https://reviews.apache.org/r/15845/diff/
> 
> 
> Testing
> -------
> 
> make check Linux (100 iterations) and OSX.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 15845: Fixed a flaky test Fixed ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15845/#review29401
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Nov. 25, 2013, 10:30 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15845/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-823
>     https://issues.apache.org/jira/browse/MESOS-823
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> - This patch can be committed first and I will address AWAIT_READY change subsequently.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_contender_detector_tests.cpp 5e4237454133edc155e74ffa04aec24ccd04c1b4 
> 
> Diff: https://reviews.apache.org/r/15845/diff/
> 
> 
> Testing
> -------
> 
> make check Linux (100 iterations) and OSX.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 15845: Fixed a flaky test Fixed ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15845/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 10:30 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-823
    https://issues.apache.org/jira/browse/MESOS-823


Repository: mesos-git


Description
-------

See summary.

- This patch can be committed first and I will address AWAIT_READY change subsequently.


Diffs
-----

  src/tests/master_contender_detector_tests.cpp 5e4237454133edc155e74ffa04aec24ccd04c1b4 

Diff: https://reviews.apache.org/r/15845/diff/


Testing
-------

make check Linux (100 iterations) and OSX.


Thanks,

Jiang Yan Xu