You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/09 08:16:28 UTC
[GitHub] [flink] curcur opened a new pull request #13567: Single task result partial record clean up
curcur opened a new pull request #13567:
URL: https://github.com/apache/flink/pull/13567
## What is the purpose of the change
Partial records happen if a record can not fit into one buffer, then the remaining part of the same record is put into the next buffer. Hence partial records only exist at the beginning of a buffer. Partial record clean-up is needed in the mode of approximate local recovery. If a record is spanning over multiple buffers, and the first (several) buffers have got lost due to the failure of the receiver task, the remaining data belonging to the same record in transition should be cleaned up.
`partialRecordLength` is the length of bytes to skip in order to start with a complete record, from position index 0 of the underlying MemorySegment. `partialRecordLength` is used in approximate local recovery to find the start position of a complete record on a BufferConsumer, so-called `partial record clean-up`.
## Brief change log
- API change to add `partialRecordLength` when creating a BufferConsumer
- Add `partialRecordLength` in `BufferWritingResultPartition` when emitRecord and `broadcastRecord`
- Update the type of buffers in PipelinedSubpartition fr`PrioritizedDeque<BufferConsumer>` to `PrioritizedDeque<BufferConsumerWithPartialRecordLength>`
## Verifying this change
- add unit tests to test partial record length
- pass existing tests to make sure the changes do not affect data write/read/transition.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706047591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706047591
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7323",
"triggerID" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d29ad82907bfe3ae9966e38c951234984c466aab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706042177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706042177
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d29ad82907bfe3ae9966e38c951234984c466aab (Fri Oct 09 08:18:29 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706047591
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d29ad82907bfe3ae9966e38c951234984c466aab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706047591
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7323",
"triggerID" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d29ad82907bfe3ae9966e38c951234984c466aab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13567: Single task result partial record clean up
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13567:
URL: https://github.com/apache/flink/pull/13567#issuecomment-706047591
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7323",
"triggerID" : "d29ad82907bfe3ae9966e38c951234984c466aab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d29ad82907bfe3ae9966e38c951234984c466aab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org