[GitHub] [jmeter] FSchumacher commented on a diff in pull request #5788: feat: add property to disable FunctionProperty caching

["FSchumacher (via GitHub)" <gi...@apache.org>]

FSchumacher commented on code in PR #5788:
URL: https://github.com/apache/jmeter/pull/5788#discussion_r1148543694


##########
xdocs/usermanual/properties_reference.xml:
##########
@@ -1339,6 +1339,14 @@ JMETER-SERVER</source>
     ORO PatternCacheLRU size.<br/>
     Defaults to: <code>1000</code>
 </property>
+<property name="function.cache.per.iteration">
+    <p>Cache function execution during test execution.</p>
+    <p>By default, JMeter caches function properties during a test iteration, however,
+    it might cause unexpected results when a component is shared across threads and the expression depends on
+    the thread variables.</p>
+    <note>The caching behaviour would likely be disabled in the upcoming versions</note>

Review Comment:
   ```suggestion
       <note>The caching behaviour will likely be disabled in an upcoming version</note>
   ```
   Looks good to me.
   Out of curiosity, have you done performance comparisons? I would think, that in most cases on modern CPUs the cache is not that important anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org