You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jonathan Eagles (Created) (JIRA)" <ji...@apache.org> on 2012/02/03 17:53:55 UTC
[jira] [Created] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
test-patch will +1 patches with added javadoc warnings
------------------------------------------------------
Key: HADOOP-8020
URL: https://issues.apache.org/jira/browse/HADOOP-8020
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 0.23.1
Reporter: Jonathan Eagles
Assignee: Jonathan Eagles
OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
{noformat}
$ cd hadoop-common-project/
$ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
$ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
11
{noformat}
{noformat}
$ cat dev-support/test-patch.properties
OK_RELEASEAUDIT_WARNINGS=0
OK_FINDBUGS_WARNINGS=0
OK_JAVADOC_WARNINGS=13
{noformat}
This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199878#comment-13199878 ]
Jonathan Eagles commented on HADOOP-8020:
-----------------------------------------
The build results won't tell us much since test-patch.properties is read in before the patch is applied.
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199860#comment-13199860 ]
Robert Joseph Evans commented on HADOOP-8020:
---------------------------------------------
Is the patch intended for trunk, 0.23, or both?
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199896#comment-13199896 ]
Jonathan Eagles commented on HADOOP-8020:
-----------------------------------------
Yes.
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles updated HADOOP-8020:
------------------------------------
Attachment: HADOOP-8020.patch
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199882#comment-13199882 ]
Hadoop QA commented on HADOOP-8020:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513148/HADOOP-8020.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/562//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/562//console
This message is automatically generated.
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Thomas Graves (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200146#comment-13200146 ]
Thomas Graves commented on HADOOP-8020:
---------------------------------------
it looks like the extra javadoc warnings in trunk are:
[WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
> [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
That file was added under HADOOP-7761. It seems like that would be good to pull into branch 23, so perhaps this patch isn't needed if the plan is to merge HADOOP-7761.
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles updated HADOOP-8020:
------------------------------------
Attachment: patchJavadocWarnings.txt.hadoop-trunk
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200136#comment-13200136 ]
Jonathan Eagles commented on HADOOP-8020:
-----------------------------------------
That is correct. This should only apply to branch-0.23
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200267#comment-13200267 ]
Suresh Srinivas commented on HADOOP-8020:
-----------------------------------------
If that is the case summary saying "Reduce the allowed Javadoc warnings from 13 to 11" would be a better title for the jira I think.
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles updated HADOOP-8020:
------------------------------------
Status: Patch Available (was: Open)
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199891#comment-13199891 ]
Suresh Srinivas commented on HADOOP-8020:
-----------------------------------------
Jonathan, you are reducing the number of allowed Javadoc warnings from 13 to 11, right?
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199867#comment-13199867 ]
Jonathan Eagles commented on HADOOP-8020:
-----------------------------------------
Both 23 and trunk have this mismatch of OK_JAVADOC_WARNINGS
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200150#comment-13200150 ]
Jonathan Eagles commented on HADOOP-8020:
-----------------------------------------
Canceling the patch until a decision on HADOOP-7761 is made
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8020) Reduce the allowed Javadoc warnings
from 13 to 11
Posted by "Jonathan Eagles (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles resolved HADOOP-8020.
-------------------------------------
Resolution: Invalid
> Reduce the allowed Javadoc warnings from 13 to 11
> -------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Jonathan Eagles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles updated HADOOP-8020:
------------------------------------
Status: Open (was: Patch Available)
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) Reduce the allowed Javadoc
warnings from 13 to 11
Posted by "Jonathan Eagles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200278#comment-13200278 ]
Jonathan Eagles commented on HADOOP-8020:
-----------------------------------------
Thanks for the catch Suresh. Updated the summary. I first it looked like this was a problem in both trunk and branch-0.23.
> Reduce the allowed Javadoc warnings from 13 to 11
> -------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8020) test-patch will +1 patches with
added javadoc warnings
Posted by "Thomas Graves (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200062#comment-13200062 ]
Thomas Graves commented on HADOOP-8020:
---------------------------------------
Jon,
I ran test-patch manually and it looks like there are currently 13 javadoc warnings on trunk and only 11 on branch 23. Can you double check that this should also apply to trunk?
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8020) Reduce the allowed Javadoc warnings
from 13 to 11
Posted by "Jonathan Eagles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles updated HADOOP-8020:
------------------------------------
Summary: Reduce the allowed Javadoc warnings from 13 to 11 (was: test-patch will +1 patches with added javadoc warnings)
> Reduce the allowed Javadoc warnings from 13 to 11
> -------------------------------------------------
>
> Key: HADOOP-8020
> URL: https://issues.apache.org/jira/browse/HADOOP-8020
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.1
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk 2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF' | grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira