You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/19 20:03:04 UTC

[jira] [Commented] (BEAM-2333) Rehydrate Pipeline from Runner API proto

    [ https://issues.apache.org/jira/browse/BEAM-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017946#comment-16017946 ] 

ASF GitHub Bot commented on BEAM-2333:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3187

    [BEAM-2333] Remove Pipeline reference from TransformHierarchy

    This change removes a direct dependency cycle between Pipeline and
    TransformHierarchy. There is still an indirect cycle through PValues, but that
    is slightly less problematic.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam TransformHierarchy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3187
    
----
commit 481f418fa832fdd5eb11b20b81a13f29e6ac7f42
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-05-19T19:57:41Z

    Remove Pipeline reference from TransformHierarchy
    
    This change removes a direct dependency cycle between Pipeline and
    TransformHierarchy. There is still an indirect cycle through PValues, but that
    is slightly less problematic.

----


> Rehydrate Pipeline from Runner API proto
> ----------------------------------------
>
>                 Key: BEAM-2333
>                 URL: https://issues.apache.org/jira/browse/BEAM-2333
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)