You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/23 19:58:46 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12892: [TIR][Transform] Remove num_unpacked_args from MakePackedAPI
Lunderberg opened a new pull request, #12892:
URL: https://github.com/apache/tvm/pull/12892
Other than a single unit test, there are no usages of this parameter in TVM, and it significantly complicates the logic of `MakePackedAPI`. Similar functionality can be had by using `MakeUnpackedAPI` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #12892: [TIR][Transform] Remove num_unpacked_args from MakePackedAPI
Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #12892:
URL: https://github.com/apache/tvm/pull/12892#issuecomment-1257733229
Thanks for doing this @Lunderberg, I've often wondered what this was for 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #12892: [TIR][Transform] Remove num_unpacked_args from MakePackedAPI
Posted by GitBox <gi...@apache.org>.
Mousius merged PR #12892:
URL: https://github.com/apache/tvm/pull/12892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a diff in pull request #12892: [TIR][Transform] Remove num_unpacked_args from MakePackedAPI
Posted by GitBox <gi...@apache.org>.
Mousius commented on code in PR #12892:
URL: https://github.com/apache/tvm/pull/12892#discussion_r980211903
##########
python/tvm/tir/transform/transform.py:
##########
@@ -402,7 +402,9 @@ def MakePackedAPI(num_unpacked_params: int = -1):
fpass : tvm.transform.Pass
The result pass
"""
- return _ffi_api.MakePackedAPI(num_unpacked_params) # type: ignore
+ num_unpacked_params: int = -1
+ assert num_unpacked_params == -1
Review Comment:
I think we can remove this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a diff in pull request #12892: [TIR][Transform] Remove num_unpacked_args from MakePackedAPI
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on code in PR #12892:
URL: https://github.com/apache/tvm/pull/12892#discussion_r980232185
##########
python/tvm/tir/transform/transform.py:
##########
@@ -402,7 +402,9 @@ def MakePackedAPI(num_unpacked_params: int = -1):
fpass : tvm.transform.Pass
The result pass
"""
- return _ffi_api.MakePackedAPI(num_unpacked_params) # type: ignore
+ num_unpacked_params: int = -1
+ assert num_unpacked_params == -1
Review Comment:
Thank you for the catch, and removed! I was iteratively stripping out `num_unpacked_params` to make sure that each step still ran, and it looks like that one slipped by.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12892: [TIR][Transform] Remove num_unpacked_args from MakePackedAPI
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12892:
URL: https://github.com/apache/tvm/pull/12892#issuecomment-1258096805
@Mousius No problem! As far as I could tell from inspection (and maybe @tqchen could verify), it looks like an early-development feature that dates back at least to 2017 (https://github.com/apache/tvm/pull/51). The usage has mostly been replaced by `MakeUnpackedAPI`, which wasn't present until 2021 (https://github.com/apache/tvm/pull/8023).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org