[GitHub] [tinkerpop] disq commented on a diff in pull request #1990: TINKERPOP-2905 Always pass `logHandler` to transporter

["disq (via GitHub)" <gi...@apache.org>]

disq commented on code in PR #1990:
URL: https://github.com/apache/tinkerpop/pull/1990#discussion_r1135989789


##########
gremlin-go/driver/transporterFactory.go:
##########
@@ -31,11 +31,17 @@ const (
 	Gorilla TransporterType = iota + 1
 )
 
-func getTransportLayer(transporterType TransporterType, url string, connSettings *connectionSettings) (transporter, error) {
+func getTransportLayer(transporterType TransporterType, url string, connSettings *connectionSettings, logHandler *logHandler) (transporter, error) {
 	var transporter transporter
 	switch transporterType {
 	case Gorilla:
-		transporter = &gorillaTransporter{url: url, connSettings: connSettings, writeChannel: make(chan []byte, writeChannelSizeDefault), wg: &sync.WaitGroup{}}
+		transporter = &gorillaTransporter{
+			url:          url,
+			logHandler:   logHandler,

Review Comment:
   The whole block was reformatted and `logHandler` was added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org