You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/11/05 17:17:51 UTC

[GitHub] [geode] kirklund opened pull request #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Fixes:
- GEODE-2644: Provide ability to configure Geode appenders in log4j2.xml
- GEODE-5789: gfsh command "change loglevel" only updates the cache.getLogger
- GEODE-5637: Flaky: SingleHopClientExecutorWithLoggingIntegrationTest fails intermittently


[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Posted by "kirklund (GitHub)" <gi...@apache.org>.
The only DistributedTest failure was unrelated to logging. Looks like RedisDUnitTest is flaky:
```
org.apache.geode.redis.RedisDistDUnitTest > testConcCreateDestroy FAILED
    org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.redis.RedisDistDUnitTest$1ConcCreateDestroy.call in VM 3 running on Host 9a0c0f5ade04 with 4 VMs
        at org.apache.geode.test.dunit.VM.invoke(VM.java:433)
        at org.apache.geode.test.dunit.VM.invoke(VM.java:402)
        at org.apache.geode.test.dunit.VM.invoke(VM.java:384)
        at org.apache.geode.redis.RedisDistDUnitTest.testConcCreateDestroy(RedisDistDUnitTest.java:197)

        Caused by:
        redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketTimeoutException: Read timed out

            Caused by:
            java.net.SocketTimeoutException: Read timed out
```

[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Posted by "kirklund (GitHub)" <gi...@apache.org>.
I've written some benchmarks to compare the performance impact of these new appenders versus the old appenders. Results look good.
```
New Appenders

Benchmark                                Mode  Cnt        Score   Error  Units
CacheLoggingBenchmark.infoLogStatement  thrpt        188672.952          ops/s
CacheLoggingBenchmark.putStatement      thrpt       1530589.450          ops/s
```
```
Old Appenders

Benchmark                                Mode  Cnt        Score   Error  Units
CacheLoggingBenchmark.infoLogStatement  thrpt        143247.397          ops/s
CacheLoggingBenchmark.putStatement      thrpt       1486630.605          ops/s
```


[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Posted by "kirklund (GitHub)" <gi...@apache.org>.
@dschneider-pivotal AlertListenerMessage$Listener is an interface which is always static. I'm going to add `@TestingOnly` to the static methods and the interface. Thanks for taking the time to review this huge PR!


[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[This is an comment in an attempt to bump the concourse resource.]

[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2778: GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

Posted by "kirklund (GitHub)" <gi...@apache.org>.
The only DistributedTest failure was unrelated to logging. Looks like RedisDistDUnitTest is flaky:
```
org.apache.geode.redis.RedisDistDUnitTest > testConcCreateDestroy FAILED
    org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.redis.RedisDistDUnitTest$1ConcCreateDestroy.call in VM 3 running on Host 9a0c0f5ade04 with 4 VMs
        at org.apache.geode.test.dunit.VM.invoke(VM.java:433)
        at org.apache.geode.test.dunit.VM.invoke(VM.java:402)
        at org.apache.geode.test.dunit.VM.invoke(VM.java:384)
        at org.apache.geode.redis.RedisDistDUnitTest.testConcCreateDestroy(RedisDistDUnitTest.java:197)

        Caused by:
        redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketTimeoutException: Read timed out

            Caused by:
            java.net.SocketTimeoutException: Read timed out
```

[ Full content available at: https://github.com/apache/geode/pull/2778 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org