You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "acvictor (via GitHub)" <gi...@apache.org> on 2026/02/15 17:08:22 UTC
[PR] [CORE] Use ArrayList instead of LinkedList in Spillers [incubator-gluten]
acvictor opened a new pull request, #11619:
URL: https://github.com/apache/incubator-gluten/pull/11619
## What changes are proposed in this pull request?
This PR replaces LinkedList with ArrayList in Spillers.AppendableSpillerList. The list is only used for two operations: add() (append) and sequential for-each iteration in `spill()`. ArrayList is more efficient for both: append is amortized O(1) without allocating a Node object per element, and iteration benefits from sequential memory layout (CPU cache locality). LinkedList is faster for frequent mid-list insertions/removals, which this class never does.
## How was this patch tested?
Existing unit tests.
## Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Use ArrayList instead of LinkedList in Spillers [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11619:
URL: https://github.com/apache/incubator-gluten/pull/11619#issuecomment-3904837443
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Use ArrayList instead of LinkedList in Spillers [incubator-gluten]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn merged PR #11619:
URL: https://github.com/apache/incubator-gluten/pull/11619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Use ArrayList instead of LinkedList in Spillers [incubator-gluten]
Posted by "acvictor (via GitHub)" <gi...@apache.org>.
acvictor commented on PR #11619:
URL: https://github.com/apache/incubator-gluten/pull/11619#issuecomment-3904968372
@zhztheplayer can you please review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org