You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 19:33:46 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2407: Support peek_next_page and skip_next_page in InMemoryPageReader

tustvold commented on code in PR #2407:
URL: https://github.com/apache/arrow-rs/pull/2407#discussion_r943859419


##########
parquet/src/util/test_common/page_util.rs:
##########
@@ -166,11 +167,28 @@ impl<P: Iterator<Item = Page> + Send> PageReader for InMemoryPageReader<P> {
     }
 
     fn peek_next_page(&mut self) -> Result<Option<PageMetadata>> {
-        unimplemented!()
+        if let Some(x) = self.page_iter.peek() {
+            match x {
+                Page::DataPage { .. } => {
+                    unreachable!()

Review Comment:
   Why is this unreachable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org