You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/09 08:45:31 UTC

[GitHub] [flink] curcur commented on a change in pull request #17187: [FLINK-11250][runtime] Added method init for RecordWriter for initialization resources(OutputFlusher) outside of constructor

curcur commented on a change in pull request #17187:
URL: https://github.com/apache/flink/pull/17187#discussion_r705120234



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -647,6 +647,8 @@ void restoreInternal() throws Exception {
         closedOperators = false;
         LOG.debug("Initializing {}.", getName());
 
+        recordWriter.init();

Review comment:
       why called here separately?
   
   What's the problem of starting the thread in constructor?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org