You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "PDGGK (via GitHub)" <gi...@apache.org> on 2026/08/25 06:19:14 UTC

[PR] Keep real ThingsBoard verification isolated [iotdb-extras]

PDGGK opened a new pull request, #127:
URL: https://github.com/apache/iotdb-extras/pull/127

   ## Description
   
   ### Isolate the context-test fixture
   
   Mark the test-only `JpaAttributeDao` fixture lazy. The context tests exercise bean-definition selection and withdrawal; they do not exercise the host DAO itself. Against genuine ThingsBoard 4.3.1.2 types, eager construction also requires host-application collaborators such as `jpaExecutorService`, which this isolated module test intentionally does not bootstrap.
   
   This changes no production code. The verification guide now states the resulting proof boundary explicitly: these context assertions cover definition selection, while host-application compatibility requires a separate live ThingsBoard deployment.
   
   ### Refresh genuine-interface verification evidence
   
   Update `VERIFYING-AGAINST-THINGSBOARD.md` with the current genuine-type surface and test counts after #125:
   
   - compile-only build: 59 source files
   - genuine ThingsBoard 4.3.1.2 build: 19 source files
   - unit tests: 204 passed
   - Docker integration tests: 58 passed
   - failures, errors, and skipped tests: 0
   
   The built module contains no `org/thingsboard` classes.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for the modified test behavior.
   - [x] added comments explaining the intent of the test fixture.
   - [x] been tested against genuine ThingsBoard 4.3.1.2 types and a real IoTDB 2.0.8 Testcontainer.
   
   <hr>
   
   ##### Key changed classes and documents
   
   - `AttributesDaoConflictGuardTest`
   - `VERIFYING-AGAINST-THINGSBOARD.md`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Keep real ThingsBoard verification isolated [iotdb-extras]

Posted by "CritasWang (via GitHub)" <gi...@apache.org>.
CritasWang merged PR #127:
URL: https://github.com/apache/iotdb-extras/pull/127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org