You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Benura Abeywardena (Jira)" <ji...@apache.org> on 2021/03/13 16:16:00 UTC
[jira] [Comment Edited] (FINERACT-1270) Unify Fineract 3 (!)
different email sender utilities
[ https://issues.apache.org/jira/browse/FINERACT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300909#comment-17300909 ]
Benura Abeywardena edited comment on FINERACT-1270 at 3/13/21, 4:15 PM:
------------------------------------------------------------------------
[~vorburger] This is a good point. Will resolve the issue https://issues.apache.org/jira/browse/FINERACT-1335?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel first. [~francisguchie] Need your help :)
was (Author: blasan):
[~vorburger] This is a good point. Will resolve the issue https://issues.apache.org/jira/browse/FINERACT-1335?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel first. [~francisguchie] Need you help :)
> Unify Fineract 3 (!) different email sender utilities
> -----------------------------------------------------
>
> Key: FINERACT-1270
> URL: https://issues.apache.org/jira/browse/FINERACT-1270
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Priority: Major
>
> While looking into addressing FINERACT-1092, I've just noticed that the Fineract code base has not 1 and not 2 but 3 (!) classes which send email:
> * org.apache.fineract.infrastructure.core.service.GmailBackedPlatformEmailService
> * org.apache.fineract.infrastructure.campaigns.email.service.EmailMessageJobEmailServiceImpl
> * org.apache.fineract.infrastructure.reportmailingjob.service.ReportMailingJobEmailServiceImpl
> The best thing is that 2 of those use {{org.springframework.mail.javamail}} whereas the 3rd (and probably oldest?) uses {{org.apache.commons.mail}} instead.
> They, apparently, also use 3 completely different mail server configurations in the database! This doesn't make any sense - I cannot imagine anyone wanting to use 3 different mail server for 3 purposes.
> Let's merge all this? Best step by step, in a series of several small PRs, instead of 1 big one. The DB change may also require DB migration scripts to remove the old config (depending on how we want to "migrate").
--
This message was sent by Atlassian Jira
(v8.3.4#803005)