You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/04/22 20:03:17 UTC
[GitHub] commons-lang pull request #263: Use String#contains where possible
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/263
Use String#contains where possible
Since the project defines a JDK 7 source compatibility, it's safe to use JDK 5's features.
This patch replaces usages of `String#indexOf` with `String#contains` where possible to make the code easier to read and maintain.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang contains
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit 8fff6277fd22866753be3d2b3d717a32fba428a3
Author: Allon Mureinik <am...@redhat.com>
Date: 2017-04-22T19:59:38Z
Use String#contains where possible
Since the project defines a JDK 7 source compatibility, it's safe to
use JDK 5's features.
This patch replaces usages of String#indexOf with String#contains
where possible to make the code easier to read and maintain.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #263: Use String#contains where possible
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #263: Use String#contains where possible
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/263
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #263: Use String#contains where possible
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/263
[](https://coveralls.io/builds/11196975)
Coverage remained the same at 94.655% when pulling **8fff6277fd22866753be3d2b3d717a32fba428a3 on mureinik:contains** into **8cafd87c83f4197f7e8d14de8cba453c844266c0 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---