You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:06:54 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new issue #5766: `go vet`: unreachable code
zrhoffman opened a new issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Ops
- Traffic Ops ORT
## Current behavior:
<!-- Describe how the bug manifests -->
`go vet -unreachable ./...` finds 2 issues:
<table><thead><th>Message</th><th>Line of code</th></thead><tbody>
<tr><td><code>unreachable code</code></td><td>
https://github.com/apache/trafficcontrol/blob/61e423f33b8f4b61a6228c9e3d0fbac646d231f2/traffic_ops_ort/plugin_verifier/plugin_verifier.go#L261
https://github.com/apache/trafficcontrol/blob/61e423f33b8f4b61a6228c9e3d0fbac646d231f2/traffic_ops/traffic_ops_golang/login/logout_test.go#L135
</td></tr>
</tbody></table>
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
`go vet -unreachable ./...` should find 0 issues.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
```shell
go vet -unreachable ./...
```
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] Ayushsunny commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
Ayushsunny commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-824608848
Hello @zrhoffman Can I work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] Ayushsunny commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
Ayushsunny commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-834604569
Hello @zrhoffman could you review this [PR](https://github.com/apache/trafficcontrol/pull/5823) please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-825168245
If you want more info on what unreachable code is, see: https://en.wikipedia.org/wiki/Unreachable_code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-834630022
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-824625002
Go for it! Looks like @ocket8888 has already assigned you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman closed issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
zrhoffman closed issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] Ayushsunny commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
Ayushsunny commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-824633306
Well, Thankyou for assigning me @ocket8888 but as I am new to open source, Can you help me more to get this issue solved I mean what exactly I need to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-824963435
If you start from the repository root and run the command `go vet -unreachable ./...` it should tell you almost exactly what you need to do to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] Ayushsunny commented on issue #5766: `go vet`: unreachable code
Posted by GitBox <gi...@apache.org>.
Ayushsunny commented on issue #5766:
URL: https://github.com/apache/trafficcontrol/issues/5766#issuecomment-825165916
> go vet -unreachable ./...
But Sir @ocket8888 It's telling the same thing mentioned above in the issue -
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org