You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/26 08:55:27 UTC
[GitHub] [airflow] BobDu opened a new pull request, #28590: collect sawarning as error in pytest
BobDu opened a new pull request, #28590:
URL: https://github.com/apache/airflow/pull/28590
Signed-off-by: BobDu <i...@bobdu.cc>
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
related: #28198 #28544
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28590: collect sawarning as error in pytest
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28590:
URL: https://github.com/apache/airflow/pull/28590#issuecomment-1366560903
@BobDu I think this changes conflicts with [pytest-capture-warnings](https://github.com/athinkingape/pytest-capture-warnings) plugin. I check locally and with our current settings and plugins nothing happen, unfortunetly
Without disable `pytest-capture-warnings`
---
```console
root@a33668319fad:/opt/airflow# pytest tests/jobs/test_scheduler_job.py::TestSchedulerJob
==================================================================== test session starts ====================================================================
platform linux -- Python 3.7.16, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: cov-4.0.0, asyncio-0.20.3, rerunfailures-9.1.1, instafail-0.4.2, anyio-3.6.2, timeouts-1.2.1, xdist-3.1.0, requests-mock-1.10.0, capture-warnings-0.0.4, httpx-0.21.2, time-machine-2.8.2
asyncio: mode=strict
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 142 items
...
All Warning errors can be found in the warnings.txt file.
...
============================================================== 139 passed, 3 skipped in 17.45s ==============================================================
```
Disable `pytest-capture-warnings`
---
```console
root@a33668319fad:/opt/airflow# pytest -p no:capture_warnings tests/jobs/test_scheduler_job.py::TestSchedulerJob
==================================================================== test session starts ====================================================================
platform linux -- Python 3.7.16, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: cov-4.0.0, asyncio-0.20.3, rerunfailures-9.1.1, instafail-0.4.2, anyio-3.6.2, timeouts-1.2.1, xdist-3.1.0, requests-mock-1.10.0, httpx-0.21.2, time-machine-2.8.2
asyncio: mode=strict
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 142 items
...
================================================================== short test summary info ==================================================================
...
FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies_nothing - sqlalchemy.exc.SAWarning: SELECT statement has a cartesian product ...
FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies - sqlalchemy.exc.SAWarning: SELECT statement has a cartesian product between ...
FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies_handle_failure_callbacks_are_correctly_passed_to_dag_processor - sqlalchemy.e...
================================================== 3 failed, 136 passed, 3 skipped, 26 warnings in 18.43s ===================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #28590: collect sawarning as error in pytest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28590:
URL: https://github.com/apache/airflow/pull/28590#issuecomment-1496752576
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #28590: collect sawarning as error in pytest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28590:
URL: https://github.com/apache/airflow/pull/28590#issuecomment-1428898094
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #28590: collect sawarning as error in pytest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #28590: collect sawarning as error in pytest
URL: https://github.com/apache/airflow/pull/28590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BobDu commented on pull request #28590: collect sawarning as error in pytest
Posted by GitBox <gi...@apache.org>.
BobDu commented on PR #28590:
URL: https://github.com/apache/airflow/pull/28590#issuecomment-1367695506
> @BobDu I think this changes conflicts with [pytest-capture-warnings](https://github.com/athinkingape/pytest-capture-warnings) plugin. I check locally and with our current settings and plugins nothing happen, unfortunetly
covert to draft and i will explore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org