You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/07 14:02:31 UTC

[GitHub] tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config

tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config
URL: https://github.com/apache/flink/pull/6339#discussion_r208239960
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
 ##########
 @@ -239,6 +240,15 @@ protected int runPrivileged(Configuration config, Configuration dynamicPropertie
 
 			// ----------------- (2) start the actor system -------------------
 
+			// Enlarge thread pool to improve the performance of ActorSystem.
+			config.setDouble(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_FACTOR, 1.0);
+			config.setInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MIN, 16);
+			config.setInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MAX, 64);
+			config.setInteger(AkkaOptions.SERVER_SOCKET_WORKER_POOL_SIZE_MIN, 8);
+			config.setInteger(AkkaOptions.SERVER_SOCKET_WORKER_POOL_SIZE_MAX, 64);
+			config.setInteger(AkkaOptions.CLIENT_SOCKET_WORKER_POOL_SIZE_MIN, 8);
+			config.setInteger(AkkaOptions.CLIENT_SOCKET_WORKER_POOL_SIZE_MIN, 64);
 
 Review comment:
   I think we should not overwrite the configuration settings here. The user should specify them in his `flink-conf.yaml`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services