[GitHub] merlimat commented on a change in pull request #1179: Avoid printing exception stack trace on lookup connection failures

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1179: Avoid printing exception stack trace on lookup connection failures
URL: https://github.com/apache/incubator-pulsar/pull/1179#discussion_r166085940
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
 ##########
 @@ -131,7 +132,7 @@ public BinaryProtoLookupService(PulsarClientImpl client, String serviceUrl, bool
             }).exceptionally((sendException) -> {
                 // lookup failed
                 log.warn("[{}] failed to send lookup request : {}", destination.toString(), sendException.getMessage(),
 
 Review comment:
   the `null` is not getting actually printed, the exception message is always printed (and that's what gets added in the `{}`). This is just to prevent the stack trace after the log line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services