You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/26 21:51:22 UTC
[GitHub] [maven] michael-o opened a new pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o opened a new pull request #419:
URL: https://github.com/apache/maven/pull/419
… be more easily changed
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549105819
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
That's correct, but we don't have a better way. Settings with Maven 5 could natively support repositories. Do you see a better way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549106196
##########
File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal
// Code taken from LegacyRepositorySystem
//
- public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request )
Review comment:
True, I chose to use a highly invasive approach. One could use the same approach like in the original commits. Retain public method, but return either `null` or `InvalidRepositoryException`. The contract does not describe any behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108923
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
So you want to bump settings model to 2.0.0 and introduce repos there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549123187
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
So do you want to move this after settings 1.2.0 or can we start with a profile and then move to a separate repo? Implementing 1.2.0 will take some time...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108923
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
So you want to bump settings model to 2.0.0 and introduce repos there? What will happen when pre-4.0.0 will try to read this settings file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108816
##########
File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal
// Code taken from LegacyRepositorySystem
//
- public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request )
Review comment:
So leave as-is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108800
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
No, it is not. Colon is invalid for group/artifact ids. For element ids nothing is enforced. See: https://issues.apache.org/jira/browse/MNG-7052. I intionally did not want to use a period because people might have used `maven.repo...`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549110606
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
We also do not have an official documentation what is valid or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #419:
URL: https://github.com/apache/maven/pull/419#issuecomment-751401449
Requires https://github.com/apache/maven-integration-testing/pull/93, https://github.com/apache/maven-integration-testing/pull/94, https://github.com/apache/maven-integration-testing/pull/95, https://github.com/apache/maven-integration-testing/pull/96.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108105
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
To me the `settings.xml` is a Maven specific file (unlike the `pom.xml`). I see this as an opportunity to improve the `settings.xml` right now. I don't like the idea of a temporary solution now of which we know it'll be changed. Those temporary hybrid style settings will be there forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549106505
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
I was never a fan of implicit deactivation because it seems to much magic to me. My initial idea was to name the profile. Same approach I have used with Maven Resolver Redisson Sync Context. I want to reserve a URN-style id namespace to use. In Resolver I have used: `maven:resolver:` prefix. Here I would like to use `maven:core:central-repo`, at least the `maven:core:` prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549110820
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
version 1.2.0 would be good enough, we're only adding stuff, not breaking things.
And we're talking about `config/settings.xml`, not `.m2./settings.xml`. It must be possible to keep the latter at 1.0.0 or 1.1.0, while improving the first one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549150845
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
https://issues.apache.org/jira/browse/MNG-7059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549356949
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,14 +244,43 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <id>maven:core:central-repo</id>
+ <repositories>
+ <repository>
+ <id>central</id>
+ <name>Central Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ </repository>
+ </repositories>
+
+ <pluginRepositories>
+ <pluginRepository>
+ <id>central</id>
+ <name>Central Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <releases>
+ <updatePolicy>never</updatePolicy>
+ </releases>
+ </pluginRepository>
+ </pluginRepositories>
+ </profile>
</profiles>
<!-- activeProfiles
| List of profiles that are active for all builds.
|
+ -->
<activeProfiles>
- <activeProfile>alwaysActiveProfile</activeProfile>
- <activeProfile>anotherAlwaysActiveProfile</activeProfile>
+ <activeProfile>maven:core:central-repo</activeProfile>
Review comment:
I can't offer anything better until settings don't change. Take your time and let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549107685
##########
File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal
// Code taken from LegacyRepositorySystem
//
- public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request )
Review comment:
Ok, let's see what will happen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549111039
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
The implementation of ModelValidator is quite clear about the definition of `id`, but former Maven committers forget to do a strict validation for the complete model.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549152683
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
Added a profile. Have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549110466
##########
File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal
// Code taken from LegacyRepositorySystem
//
- public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request )
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549349372
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,14 +244,43 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <id>maven:core:central-repo</id>
+ <repositories>
+ <repository>
+ <id>central</id>
+ <name>Central Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ </repository>
+ </repositories>
+
+ <pluginRepositories>
+ <pluginRepository>
+ <id>central</id>
+ <name>Central Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <releases>
+ <updatePolicy>never</updatePolicy>
+ </releases>
+ </pluginRepository>
+ </pluginRepositories>
+ </profile>
</profiles>
<!-- activeProfiles
| List of profiles that are active for all builds.
|
+ -->
<activeProfiles>
- <activeProfile>alwaysActiveProfile</activeProfile>
- <activeProfile>anotherAlwaysActiveProfile</activeProfile>
+ <activeProfile>maven:core:central-repo</activeProfile>
Review comment:
I don't like this approach. Let's invest time to do it correct, i.e. without profiles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549099926
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
To me we're now abusing a profile because it is not yet possible to specify these at a higher level. The `default` profile could contain much more.
##########
File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal
// Code taken from LegacyRepositorySystem
//
- public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request )
Review comment:
I don't know where this code is used, but it is public and I think this class is accessible by all plugins.
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
Here's the real issue. This means: activate if no other profiles are being activated. So if I run `mvn -P my-profile`, this one will be disabled, meaning we won't have remote repoitories.
The proper way to activate is by using `<activeProfiles>`. Again a sign to me we need to change the settings.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549107773
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
Officially `:` is not a valid character for ids, but I'm not sure if this was ever validated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549123105
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
The `DefaultModelValidator` retains a negative list of characters, not a positive one. Are you referring to another validation? I am confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549110998
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
Correct, makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org