You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nifi.apache.org by ToivoAdams <gi...@git.apache.org> on 2016/03/21 21:12:38 UTC

[GitHub] nifi pull request: NIFI-1613 Initial version, try to improve conve...

GitHub user ToivoAdams opened a pull request:

    https://github.com/apache/nifi/pull/293

    NIFI-1613 Initial version, try to improve conversion for different SQ…

    Initial version.
    1. New method createSqlStringValue(), placeholder for future logic
    2. New test testCreateSqlStringValue()
    3. Refactored TestConvertJSONToSQL. 
      Setting up Connection pooling is expensive operation.
      So let's do this only once and reuse MockDBCPService in each test.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ToivoAdams/nifi nifi-1613

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #293
    
----
commit 7c2eea7902f81456a880853d782615c8874a38a8
Author: Toivo Adams <to...@gmail.com>
Date:   2016-03-20T19:13:15Z

    NIFI-1613 Initial version, try to improve conversion for different SQL types. New test and refactored existing test to reuse DBCP service.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #293: NIFI-1613 Initial version, try to improve conversion...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/293


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #293: NIFI-1613 Initial version, try to improve conversion for di...

Posted by joewitt <gi...@git.apache.org>.

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/293
  
    I plan to close out this PR in a stale PR sweep soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #293: NIFI-1613 Initial version, try to improve conversion for di...

Posted by trixpan <gi...@git.apache.org>.

Github user trixpan commented on the issue:

    https://github.com/apache/nifi/pull/293
  
    @ToivoAdams is this ready for review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #293: NIFI-1613 Initial version, try to improve conversion for di...

Posted by ijokarumawak <gi...@git.apache.org>.

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/293
  
    I've taken over the proposed change into #1976 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---