You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2018/09/23 06:09:19 UTC
New precommit job 'retest this please' trick
Hi ZooKeepers,
we have enhanced the "precommit" automated QA testing.
Before merging any patch the committer should wait for a "green light" on CI,
but unfortunately we have a few flaky tests which are very annoying.
Now any Apache Committer, member of the 'apache' organization on
github, is able to restart the QA job just by simply adding a single
line comment
retest this please
I will update the wiki accordingly
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
The job on CI is
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
Cheers
Enrico
Re: New precommit job 'retest this please' trick
Posted by Fangmin Lv <lv...@gmail.com>.
This makes things much easier! Thanks a lot for setting this up!
Fangmin
On Tue, Sep 25, 2018 at 10:37 AM Brian Nixon <br...@gmail.com>
wrote:
> Excellent!
>
>
> On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár <an...@apache.org> wrote:
>
> > Awesome!
> >
> >
> >
> > On 09/24/2018 06:27 PM, Michael Han wrote:
> > >>> How the new process any different from that?
> > > Jenkins job triggered by "Rebuild" button can't write back the job
> result
> > > to github, leading to a yellow pending check status even after the job
> > > finished; while "test this please" does not have this issue.
> > >
> > >
> > > On Mon, Sep 24, 2018 at 7:01 AM, Andor Molnar
> <andor@cloudera.com.invalid
> > >
> > > wrote:
> > >
> > >> I usually logged in to Jenkins for other reasons, but that's also fine
> > to
> > >> have this option.
> > >>
> > >> Cheers
> > >> Andor
> > >>
> > >>
> > >>
> > >> On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli <eolivelli@gmail.com
> >
> > >> wrote:
> > >>
> > >>> Il lun 24 set 2018, 15:25 Andor Molnar <an...@cloudera.com.invalid>
> ha
> > >>> scritto:
> > >>>
> > >>>> Thanks Enrico. Afaik the Rebuild button was already available for
> > >>>> committers.
> > >>>> How the new process any different from th
> > >>>>
> > >>> In order to relaunch tests you do not need to go to jenkins but
> simply
> > >> add
> > >>> a 'retest this please' comment on the PR
> > >>>
> > >>> Much simpler IMO
> > >>>
> > >>>
> > >>> Enrico
> > >>>
> > >>>
> > >>>> Andor
> > >>>>
> > >>>>
> > >>>> On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <
> eolivelli@gmail.com
> > >
> > >>>> wrote:
> > >>>>
> > >>>>> Hi ZooKeepers,
> > >>>>> we have enhanced the "precommit" automated QA testing.
> > >>>>> Before merging any patch the committer should wait for a "green
> > >> light"
> > >>> on
> > >>>>> CI,
> > >>>>> but unfortunately we have a few flaky tests which are very
> annoying.
> > >>>>>
> > >>>>> Now any Apache Committer, member of the 'apache' organization on
> > >>>>> github, is able to restart the QA job just by simply adding a
> single
> > >>>>> line comment
> > >>>>>
> > >>>>> retest this please
> > >>>>>
> > >>>>> I will update the wiki accordingly
> > >>>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > >> HowToContribute
> > >>>>> The job on CI is
> > >>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> > >>>>>
> > >>>>> Cheers
> > >>>>> Enrico
> > >>>>>
> > >>> --
> > >>>
> > >>>
> > >>> -- Enrico Olivelli
> > >>>
> >
> >
>
Re: New precommit job 'retest this please' trick
Posted by Brian Nixon <br...@gmail.com>.
Excellent!
On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár <an...@apache.org> wrote:
> Awesome!
>
>
>
> On 09/24/2018 06:27 PM, Michael Han wrote:
> >>> How the new process any different from that?
> > Jenkins job triggered by "Rebuild" button can't write back the job result
> > to github, leading to a yellow pending check status even after the job
> > finished; while "test this please" does not have this issue.
> >
> >
> > On Mon, Sep 24, 2018 at 7:01 AM, Andor Molnar <andor@cloudera.com.invalid
> >
> > wrote:
> >
> >> I usually logged in to Jenkins for other reasons, but that's also fine
> to
> >> have this option.
> >>
> >> Cheers
> >> Andor
> >>
> >>
> >>
> >> On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli <eo...@gmail.com>
> >> wrote:
> >>
> >>> Il lun 24 set 2018, 15:25 Andor Molnar <an...@cloudera.com.invalid> ha
> >>> scritto:
> >>>
> >>>> Thanks Enrico. Afaik the Rebuild button was already available for
> >>>> committers.
> >>>> How the new process any different from th
> >>>>
> >>> In order to relaunch tests you do not need to go to jenkins but simply
> >> add
> >>> a 'retest this please' comment on the PR
> >>>
> >>> Much simpler IMO
> >>>
> >>>
> >>> Enrico
> >>>
> >>>
> >>>> Andor
> >>>>
> >>>>
> >>>> On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <eolivelli@gmail.com
> >
> >>>> wrote:
> >>>>
> >>>>> Hi ZooKeepers,
> >>>>> we have enhanced the "precommit" automated QA testing.
> >>>>> Before merging any patch the committer should wait for a "green
> >> light"
> >>> on
> >>>>> CI,
> >>>>> but unfortunately we have a few flaky tests which are very annoying.
> >>>>>
> >>>>> Now any Apache Committer, member of the 'apache' organization on
> >>>>> github, is able to restart the QA job just by simply adding a single
> >>>>> line comment
> >>>>>
> >>>>> retest this please
> >>>>>
> >>>>> I will update the wiki accordingly
> >>>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> >> HowToContribute
> >>>>> The job on CI is
> >>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> >>>>>
> >>>>> Cheers
> >>>>> Enrico
> >>>>>
> >>> --
> >>>
> >>>
> >>> -- Enrico Olivelli
> >>>
>
>
Re: New precommit job 'retest this please' trick
Posted by Andor Molnár <an...@apache.org>.
Awesome!
On 09/24/2018 06:27 PM, Michael Han wrote:
>>> How the new process any different from that?
> Jenkins job triggered by "Rebuild" button can't write back the job result
> to github, leading to a yellow pending check status even after the job
> finished; while "test this please" does not have this issue.
>
>
> On Mon, Sep 24, 2018 at 7:01 AM, Andor Molnar <an...@cloudera.com.invalid>
> wrote:
>
>> I usually logged in to Jenkins for other reasons, but that's also fine to
>> have this option.
>>
>> Cheers
>> Andor
>>
>>
>>
>> On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> Il lun 24 set 2018, 15:25 Andor Molnar <an...@cloudera.com.invalid> ha
>>> scritto:
>>>
>>>> Thanks Enrico. Afaik the Rebuild button was already available for
>>>> committers.
>>>> How the new process any different from th
>>>>
>>> In order to relaunch tests you do not need to go to jenkins but simply
>> add
>>> a 'retest this please' comment on the PR
>>>
>>> Much simpler IMO
>>>
>>>
>>> Enrico
>>>
>>>
>>>> Andor
>>>>
>>>>
>>>> On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi ZooKeepers,
>>>>> we have enhanced the "precommit" automated QA testing.
>>>>> Before merging any patch the committer should wait for a "green
>> light"
>>> on
>>>>> CI,
>>>>> but unfortunately we have a few flaky tests which are very annoying.
>>>>>
>>>>> Now any Apache Committer, member of the 'apache' organization on
>>>>> github, is able to restart the QA job just by simply adding a single
>>>>> line comment
>>>>>
>>>>> retest this please
>>>>>
>>>>> I will update the wiki accordingly
>>>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>> HowToContribute
>>>>> The job on CI is
>>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
>>>>>
>>>>> Cheers
>>>>> Enrico
>>>>>
>>> --
>>>
>>>
>>> -- Enrico Olivelli
>>>
Re: New precommit job 'retest this please' trick
Posted by Michael Han <ha...@apache.org>.
>> How the new process any different from that?
Jenkins job triggered by "Rebuild" button can't write back the job result
to github, leading to a yellow pending check status even after the job
finished; while "test this please" does not have this issue.
On Mon, Sep 24, 2018 at 7:01 AM, Andor Molnar <an...@cloudera.com.invalid>
wrote:
> I usually logged in to Jenkins for other reasons, but that's also fine to
> have this option.
>
> Cheers
> Andor
>
>
>
> On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Il lun 24 set 2018, 15:25 Andor Molnar <an...@cloudera.com.invalid> ha
> > scritto:
> >
> > > Thanks Enrico. Afaik the Rebuild button was already available for
> > > committers.
> > > How the new process any different from th
> > >
> >
> > In order to relaunch tests you do not need to go to jenkins but simply
> add
> > a 'retest this please' comment on the PR
> >
> > Much simpler IMO
> >
> >
> > Enrico
> >
> >
> > > Andor
> > >
> > >
> > > On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > Hi ZooKeepers,
> > > > we have enhanced the "precommit" automated QA testing.
> > > > Before merging any patch the committer should wait for a "green
> light"
> > on
> > > > CI,
> > > > but unfortunately we have a few flaky tests which are very annoying.
> > > >
> > > > Now any Apache Committer, member of the 'apache' organization on
> > > > github, is able to restart the QA job just by simply adding a single
> > > > line comment
> > > >
> > > > retest this please
> > > >
> > > > I will update the wiki accordingly
> > > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> HowToContribute
> > > >
> > > > The job on CI is
> > > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> > > >
> > > > Cheers
> > > > Enrico
> > > >
> > >
> > --
> >
> >
> > -- Enrico Olivelli
> >
>
Re: New precommit job 'retest this please' trick
Posted by Andor Molnar <an...@cloudera.com.INVALID>.
I usually logged in to Jenkins for other reasons, but that's also fine to
have this option.
Cheers
Andor
On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Il lun 24 set 2018, 15:25 Andor Molnar <an...@cloudera.com.invalid> ha
> scritto:
>
> > Thanks Enrico. Afaik the Rebuild button was already available for
> > committers.
> > How the new process any different from th
> >
>
> In order to relaunch tests you do not need to go to jenkins but simply add
> a 'retest this please' comment on the PR
>
> Much simpler IMO
>
>
> Enrico
>
>
> > Andor
> >
> >
> > On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Hi ZooKeepers,
> > > we have enhanced the "precommit" automated QA testing.
> > > Before merging any patch the committer should wait for a "green light"
> on
> > > CI,
> > > but unfortunately we have a few flaky tests which are very annoying.
> > >
> > > Now any Apache Committer, member of the 'apache' organization on
> > > github, is able to restart the QA job just by simply adding a single
> > > line comment
> > >
> > > retest this please
> > >
> > > I will update the wiki accordingly
> > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> > >
> > > The job on CI is
> > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> > >
> > > Cheers
> > > Enrico
> > >
> >
> --
>
>
> -- Enrico Olivelli
>
Re: New precommit job 'retest this please' trick
Posted by Enrico Olivelli <eo...@gmail.com>.
Il lun 24 set 2018, 15:25 Andor Molnar <an...@cloudera.com.invalid> ha
scritto:
> Thanks Enrico. Afaik the Rebuild button was already available for
> committers.
> How the new process any different from th
>
In order to relaunch tests you do not need to go to jenkins but simply add
a 'retest this please' comment on the PR
Much simpler IMO
Enrico
> Andor
>
>
> On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hi ZooKeepers,
> > we have enhanced the "precommit" automated QA testing.
> > Before merging any patch the committer should wait for a "green light" on
> > CI,
> > but unfortunately we have a few flaky tests which are very annoying.
> >
> > Now any Apache Committer, member of the 'apache' organization on
> > github, is able to restart the QA job just by simply adding a single
> > line comment
> >
> > retest this please
> >
> > I will update the wiki accordingly
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> >
> > The job on CI is
> > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> >
> > Cheers
> > Enrico
> >
>
--
-- Enrico Olivelli
Re: New precommit job 'retest this please' trick
Posted by Andor Molnar <an...@cloudera.com.INVALID>.
Thanks Enrico. Afaik the Rebuild button was already available for
committers.
How the new process any different from that?
Andor
On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Hi ZooKeepers,
> we have enhanced the "precommit" automated QA testing.
> Before merging any patch the committer should wait for a "green light" on
> CI,
> but unfortunately we have a few flaky tests which are very annoying.
>
> Now any Apache Committer, member of the 'apache' organization on
> github, is able to restart the QA job just by simply adding a single
> line comment
>
> retest this please
>
> I will update the wiki accordingly
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>
> The job on CI is
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
>
> Cheers
> Enrico
>