You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/10 23:40:59 UTC
[GitHub] [openwhisk-client-js] DrewML opened a new pull request #206: Add
missing options in main.d.ts Options interface
DrewML opened a new pull request #206: Add missing options in main.d.ts Options interface
URL: https://github.com/apache/openwhisk-client-js/pull/206
Also fixed `README.md` reference around type of `auth_handler`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-client-js] rabbah commented on issue #206: Add missing
options in main.d.ts Options interface
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #206: Add missing options in main.d.ts Options interface
URL: https://github.com/apache/openwhisk-client-js/pull/206#issuecomment-597414303
Thanks @DrewML for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-client-js] codecov-io commented on issue #206: Add
missing options in main.d.ts Options interface
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #206: Add missing options in main.d.ts Options interface
URL: https://github.com/apache/openwhisk-client-js/pull/206#issuecomment-597394299
# [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/206?src=pr&el=h1) Report
> Merging [#206](https://codecov.io/gh/apache/openwhisk-client-js/pull/206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/532236924ef97c00542bca78165312c105525da6&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk-client-js/pull/206?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 14 14
Lines 425 425
=======================================
Hits 421 421
Misses 4 4
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/206?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/206?src=pr&el=footer). Last update [5322369...1c24a4a](https://codecov.io/gh/apache/openwhisk-client-js/pull/206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-client-js] DrewML commented on a change in pull request
#206: Add missing options in main.d.ts Options interface
Posted by GitBox <gi...@apache.org>.
DrewML commented on a change in pull request #206: Add missing options in main.d.ts Options interface
URL: https://github.com/apache/openwhisk-client-js/pull/206#discussion_r390673163
##########
File path: README.md
##########
@@ -69,7 +69,7 @@ ow.actions.invoke('sample').then(result => console.log(result))
```
#### using 3rd party authentication handler
-You can specify an authentication handler in `options.auth_handler` this is an object that provides a function `getAuthHeader` that returns a Promise or String to be used in the `Authorization` http header for every http request.
+You can specify an authentication handler in `options.auth_handler` this is an object that provides a function `getAuthHeader` that returns a Promise resolving to a string to be used in the `Authorization` http header for every http request.
Review comment:
The code, as written today, will throw if `options.auth_handler` returns a `string`
**Invocation of `auth_handler`**:
https://github.com/apache/openwhisk-client-js/blob/532236924ef97c00542bca78165312c105525da6/lib/client.js#L209-L216
**Usage of result**:
https://github.com/apache/openwhisk-client-js/blob/532236924ef97c00542bca78165312c105525da6/lib/client.js#L159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-client-js] rabbah merged pull request #206: Add missing
options in main.d.ts Options interface
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #206: Add missing options in main.d.ts Options interface
URL: https://github.com/apache/openwhisk-client-js/pull/206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services