[GitHub] [daffodil] mbeckerle commented on a diff in pull request #1029: Add codegen-c support for runtime length hexBinary

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #1029:
URL: https://github.com/apache/daffodil/pull/1029#discussion_r1223324181


##########
daffodil-codegen-c/src/main/scala/org/apache/daffodil/codegen/c/DaffodilCCodeGenerator.scala:
##########
@@ -278,6 +280,7 @@ object DaffodilCCodeGenerator
       case g: RepOrderedExactlyNSequenceChild => repOrderedExactlyNSequenceChild(g, cgState)
       case g: RepOrderedExpressionOccursCountSequenceChild =>
         repOrderedExpressionOccursCountSequenceChild(g, cgState)
+      case g: RepOrderedWithMinMaxSequenceChild => repOrderedWithMinMaxSequenceChild(g, cgState)

Review Comment:
   Why is this not covered? This different invocation of the code-generator for this specific kind of sequence child would seem to be a key point of this change set. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org