You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Yong Zhang <zh...@gmail.com> on 2023/03/02 07:30:12 UTC
[VOTE] Release 4.15.4, release candidate #0
Hi everyone,
Please review and vote on the release candidate #1 for version 4.15.4,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.15.4-rc0" [4] with git sha [5]
BookKeeper's KEYS file contains the PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
Please download these packages and review this release candidate:
- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review the maven repo, release tag, licenses, and any other things you
think
it is important to release.
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Release Manager
[1] https://github.com/apache/bookkeeper/pull/3831/files
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
[3]
https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
[4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
[5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
Re: [VOTE] Release 4.15.4, release candidate #0
Posted by Jia Zhai <zh...@apache.org>.
+1 (binding)
- verified packages checksum and signatures. They look good.
- the source package build and test all run successfully.
- for package bk-server,bk-all: 'bin/bookkeeper standalone' runs well.
On Mon, Mar 6, 2023 at 10:15 AM Hang Chen <ch...@apache.org> wrote:
> +1 (non-binding)
>
> Thank Yong for driving this release. Overall it looks good.
>
> - Verified signatures and checksums
> - Build from source code (MacOS jdk 11, maven 3.8.6)
> - Tested local bookie
> - Tested standalone bookie
> - Build Pulsar master code with this staging dependency and start
> Pulsar standalone cluster and run Pulsar perf produce and consume
> - Run Pulsar CI with the new BookKeeper release [1]
>
> Thanks,
> Hang
>
> [1] https://github.com/hangc0276/pulsar/pull/11
>
> Yong Zhang <zh...@gmail.com> 于2023年3月2日周四 15:30写道：
> >
> > Hi everyone,
> > Please review and vote on the release candidate #1 for version 4.15.4,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.15.4-rc0" [4] with git sha [5]
> >
> > BookKeeper's KEYS file contains the PGP keys we used to sign this
> release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review the maven repo, release tag, licenses, and any other things you
> > think
> > it is important to release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1] https://github.com/apache/bookkeeper/pull/3831/files
> > [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
> > [3]
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
> > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
> > [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
>
Re: [VOTE] Release 4.15.4, release candidate #0
Posted by Hang Chen <ch...@apache.org>.
+1 (non-binding)
Thank Yong for driving this release. Overall it looks good.
- Verified signatures and checksums
- Build from source code (MacOS jdk 11, maven 3.8.6)
- Tested local bookie
- Tested standalone bookie
- Build Pulsar master code with this staging dependency and start
Pulsar standalone cluster and run Pulsar perf produce and consume
- Run Pulsar CI with the new BookKeeper release [1]
Thanks,
Hang
[1] https://github.com/hangc0276/pulsar/pull/11
Yong Zhang <zh...@gmail.com> 于2023年3月2日周四 15:30写道：
>
> Hi everyone,
> Please review and vote on the release candidate #1 for version 4.15.4,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.15.4-rc0" [4] with git sha [5]
>
> BookKeeper's KEYS file contains the PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review the maven repo, release tag, licenses, and any other things you
> think
> it is important to release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://github.com/apache/bookkeeper/pull/3831/files
> [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
> [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
> [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
Re: [VOTE] Release 4.15.4, release candidate #0
Posted by Yong Zhang <zh...@gmail.com>.
The vote is now closed and the release was approved with
4 +1s(3 bindings and 1 non-binding);
Binding votes:
* Enrico Olivelli
* Andrey Yegorov
* Jia Zhai
Non-Binding votes:
* Hang Chen
Thanks to all guys for voting!
On Mon, 13 Mar 2023 at 10:15, Yong Zhang <zh...@gmail.com> wrote:
> The failed tests introduced by a test improvement
> <https://github.com/apache/bookkeeper/pull/3415/files>, I think it should
> be ok to close this vote first.
>
> Yong
>
> On Thu, 9 Mar 2023 at 22:18, Enrico Olivelli <eo...@gmail.com> wrote:
>
>> +1 (binding)
>>
>> - Checked signatures/checksums
>> - Built locally from sources, run some tests
>>
>> Enrico
>>
>>
>> There is one test that always fails on my machine:
>> [ERROR] Failures:
>> [ERROR]
>> org.apache.bookkeeper.test.BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour
>> [ERROR] Run 1:
>> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
>> should shutdown on losing zk session
>> [ERROR] Run 2:
>> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
>> should shutdown on losing zk session
>> [ERROR] Run 3:
>> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
>> should shutdown on losing zk session
>> [INFO]
>>
>> Il giorno gio 9 mar 2023 alle ore 01:30 Andrey Yegorov
>> <an...@datastax.com> ha scritto:
>> >
>> > +1 (binding)
>> >
>> > * reviewed release notes
>> > * tested standalone & localbookie
>> > * built from sources (Mac, OpenJDK 17)
>> > * ran some tests for bookkeeper-server
>> >
>> > On Wed, Mar 1, 2023 at 11:30 PM Yong Zhang <zh...@gmail.com>
>> > wrote:
>> >
>> > > Hi everyone,
>> > > Please review and vote on the release candidate #1 for version 4.15.4,
>> > > as follows:
>> > > [ ] +1, Approve the release
>> > > [ ] -1, Do not approve the release (please provide specific comments)
>> > >
>> > > The complete staging area is available for your review, which
>> includes:
>> > > * Release notes [1]
>> > > * The official Apache source and binary distributions to be deployed
>> to
>> > > dist.apache.org [2]
>> > > * All artifacts to be deployed to the Maven Central Repository [3]
>> > > * Source code tag "v4.15.4-rc0" [4] with git sha [5]
>> > >
>> > > BookKeeper's KEYS file contains the PGP keys we used to sign this
>> release:
>> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>> > >
>> > > Please download these packages and review this release candidate:
>> > >
>> > > - Review release notes
>> > > - Download the source package (verify shasum, and asc) and follow the
>> > > instructions to build and run the bookkeeper service.
>> > > - Download the binary package (verify shasum, and asc) and follow the
>> > > instructions to run the bookkeeper service.
>> > > - Review the maven repo, release tag, licenses, and any other things
>> you
>> > > think
>> > > it is important to release.
>> > >
>> > > The vote will be open for at least 72 hours. It is adopted by majority
>> > > approval, with at least 3 PMC affirmative votes.
>> > >
>> > > Thanks,
>> > > Release Manager
>> > >
>> > > [1] https://github.com/apache/bookkeeper/pull/3831/files
>> > > [2]
>> > >
>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
>> > > [3]
>> > >
>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
>> > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
>> > > [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
>> > >
>> >
>> >
>> > --
>> > Andrey Yegorov
>>
>
Re: [VOTE] Release 4.15.4, release candidate #0
Posted by Yong Zhang <zh...@gmail.com>.
The failed tests introduced by a test improvement
<https://github.com/apache/bookkeeper/pull/3415/files>, I think it should
be ok to close this vote first.
Yong
On Thu, 9 Mar 2023 at 22:18, Enrico Olivelli <eo...@gmail.com> wrote:
> +1 (binding)
>
> - Checked signatures/checksums
> - Built locally from sources, run some tests
>
> Enrico
>
>
> There is one test that always fails on my machine:
> [ERROR] Failures:
> [ERROR]
> org.apache.bookkeeper.test.BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour
> [ERROR] Run 1:
> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
> should shutdown on losing zk session
> [ERROR] Run 2:
> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
> should shutdown on losing zk session
> [ERROR] Run 3:
> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
> should shutdown on losing zk session
> [INFO]
>
> Il giorno gio 9 mar 2023 alle ore 01:30 Andrey Yegorov
> <an...@datastax.com> ha scritto:
> >
> > +1 (binding)
> >
> > * reviewed release notes
> > * tested standalone & localbookie
> > * built from sources (Mac, OpenJDK 17)
> > * ran some tests for bookkeeper-server
> >
> > On Wed, Mar 1, 2023 at 11:30 PM Yong Zhang <zh...@gmail.com>
> > wrote:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #1 for version 4.15.4,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.15.4-rc0" [4] with git sha [5]
> > >
> > > BookKeeper's KEYS file contains the PGP keys we used to sign this
> release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review the maven repo, release tag, licenses, and any other things
> you
> > > think
> > > it is important to release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Release Manager
> > >
> > > [1] https://github.com/apache/bookkeeper/pull/3831/files
> > > [2]
> > >
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
> > > [3]
> > >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
> > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
> > > [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
> > >
> >
> >
> > --
> > Andrey Yegorov
>
Re: [VOTE] Release 4.15.4, release candidate #0
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
- Checked signatures/checksums
- Built locally from sources, run some tests
Enrico
There is one test that always fails on my machine:
[ERROR] Failures:
[ERROR] org.apache.bookkeeper.test.BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour
[ERROR] Run 1:
BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
should shutdown on losing zk session
[ERROR] Run 2:
BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
should shutdown on losing zk session
[ERROR] Run 3:
BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie
should shutdown on losing zk session
[INFO]
Il giorno gio 9 mar 2023 alle ore 01:30 Andrey Yegorov
<an...@datastax.com> ha scritto:
>
> +1 (binding)
>
> * reviewed release notes
> * tested standalone & localbookie
> * built from sources (Mac, OpenJDK 17)
> * ran some tests for bookkeeper-server
>
> On Wed, Mar 1, 2023 at 11:30 PM Yong Zhang <zh...@gmail.com>
> wrote:
>
> > Hi everyone,
> > Please review and vote on the release candidate #1 for version 4.15.4,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.15.4-rc0" [4] with git sha [5]
> >
> > BookKeeper's KEYS file contains the PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review the maven repo, release tag, licenses, and any other things you
> > think
> > it is important to release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1] https://github.com/apache/bookkeeper/pull/3831/files
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
> > [3]
> > https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
> > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
> > [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
> >
>
>
> --
> Andrey Yegorov
Re: [VOTE] Release 4.15.4, release candidate #0
Posted by Andrey Yegorov <an...@datastax.com>.
+1 (binding)
* reviewed release notes
* tested standalone & localbookie
* built from sources (Mac, OpenJDK 17)
* ran some tests for bookkeeper-server
On Wed, Mar 1, 2023 at 11:30 PM Yong Zhang <zh...@gmail.com>
wrote:
> Hi everyone,
> Please review and vote on the release candidate #1 for version 4.15.4,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.15.4-rc0" [4] with git sha [5]
>
> BookKeeper's KEYS file contains the PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review the maven repo, release tag, licenses, and any other things you
> think
> it is important to release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://github.com/apache/bookkeeper/pull/3831/files
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1080
> [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0
> [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf
>
--
Andrey Yegorov