You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/12 14:18:36 UTC
[GitHub] [camel-website] shreyaag770 opened a new pull request #202: Swoosh
shreyaag770 opened a new pull request #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202
I changed dark colors in Swoosh animation with lighter shades to increase the visibility of text.
## Before:
![s1](https://user-images.githubusercontent.com/43489853/76509363-eb4f1080-6475-11ea-8cc3-bb3fc3d9284b.png)
## After:
![s3](https://user-images.githubusercontent.com/43489853/76530888-5f9bab00-649a-11ea-8b3e-3bbfc9a6e4ec.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 removed a comment on issue #202: Swoosh
Posted by GitBox <gi...@apache.org>.
shreyaag770 removed a comment on issue #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#issuecomment-602823660
oh! I didn't know about squashing commits. Thanks a lot! @zregvart but I guess, I have lost this branch or I don't know, some error is there can I send another PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #202: Swoosh
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#202: Swoosh
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#discussion_r398432071
##########
File path: antora-ui-camel/src/css/blog.css
##########
@@ -153,4 +153,4 @@ article.blog p {
.blog.list {
flex-direction: row;
}
-}
+}
Review comment:
This change is causing lint check to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #202: Swoosh
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#issuecomment-602839587
Oh! I didn't know about squashing commits. Thanks a lot! @zregvart but I guess, I have lost this branch or I don't know some error is there. I have sent another PR #263 for this. Please review #263 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #202: Swoosh
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#issuecomment-598828886
@zregvart I get your point and tried for a better combination of colors. Please have a look at it.
Also, I remove the changes made on the blog previous/next links.
![c1](https://user-images.githubusercontent.com/43489853/76643405-f5a70280-657a-11ea-9635-9aef0ab743a3.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#202: Swoosh
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#discussion_r392680427
##########
File path: antora-ui-camel/src/css/blog.css
##########
@@ -67,7 +67,7 @@ article.blog p {
}
.blog a.arrow {
- font-size: 1rem;
+ font-size: 2rem;
Review comment:
This change also belongs only to #193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #202: Swoosh
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#issuecomment-599268648
Done! @zregvart and I am really sorry, I forgot one change earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#202: Swoosh
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#discussion_r398432215
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -249,7 +249,11 @@ section.frontpage h1 {
flex-direction: column;
}
+ section.frontpage.projects .project p:nth-child(2) {
+ text-align: center;
+ }
+
section.frontpage.projects .project p:nth-child(3) {
text-align: center;
}
-}
+}
Review comment:
We need a newline at the end of the file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #202: Swoosh
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#issuecomment-602823660
oh! I didn't know about squashing commits. Thanks a lot! @zregvart but I guess, I have lost this branch or I don't know, some error is there can I send another PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #202: Swoosh
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #202: Swoosh
URL: https://github.com/apache/camel-website/pull/202#issuecomment-604326584
Closing in favour of #263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services