You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/19 11:52:21 UTC

[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

CalvinKirs opened a new pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102


   this closes #1100 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102#discussion_r787688804



##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -693,6 +693,7 @@ The text of each license is the standard Apache 2.0 license.
      (The Apache Software License, Version 2.0) Commons Logging (commons-logging:commons-logging:1.1.3 - http://commons.apache.org/proper/commons-logging/)
      (Apache 2) Objenesis (org.objenesis:objenesis:2.5.1 - http://objenesis.org)
      (The Apache Software License, Version 2.0) Apache Commons Math (org.apache.commons:commons-math3:3.5 - http://commons.apache.org/proper/commons-math/)
+     (The Apache Software License, Version 2.0) Apache SkyWalking : 8.9.0 (https://github.com/apache/skywalking/)

Review comment:
       yup, we don't need to keep this in binary tar, removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102#issuecomment-1016432626


   Thanks:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102#issuecomment-1016436722


   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102#issuecomment-1016394569


   @wu-sheng hi, please help to see, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] zhongjiajie merged pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wu-sheng commented on a change in pull request #1102: [SeaTunnel#1100]Add SkyWalking LICENSE

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1102:
URL: https://github.com/apache/incubator-seatunnel/pull/1102#discussion_r787676068



##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -693,6 +693,7 @@ The text of each license is the standard Apache 2.0 license.
      (The Apache Software License, Version 2.0) Commons Logging (commons-logging:commons-logging:1.1.3 - http://commons.apache.org/proper/commons-logging/)
      (Apache 2) Objenesis (org.objenesis:objenesis:2.5.1 - http://objenesis.org)
      (The Apache Software License, Version 2.0) Apache Commons Math (org.apache.commons:commons-math3:3.5 - http://commons.apache.org/proper/commons-math/)
+     (The Apache Software License, Version 2.0) Apache SkyWalking : 8.9.0 (https://github.com/apache/skywalking/)

Review comment:
       Do you include this script into the binary tar? If not, this license doesn't need to update.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org