[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #503: nimble/gatt: Queuing of Partial Reading in ble_gattc_read_long

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #503: nimble/gatt: Queuing of Partial Reading in ble_gattc_read_long
URL: https://github.com/apache/mynewt-nimble/pull/503#discussion_r303370072
 
 

 ##########
 File path: nimble/host/src/ble_gattc.c
 ##########
 @@ -3172,17 +3176,17 @@ ble_gattc_read_long_rx_read_rsp(struct ble_gattc_proc *proc, int status,
 
     data_len = OS_MBUF_PKTLEN(*om);
 
-    attr.handle = proc->read_long.handle;
-    attr.offset = proc->read_long.offset;
-    attr.om = *om;
-
-    /* Report partial payload to application. */
-    rc = ble_gattc_read_long_cb(proc, status, 0, &attr);
+    /* Queue Partial Reading. */
 
 Review comment:
   I'd just create new API for this, e.g. `ble_gattc_read_long_full` (or some smarter name) which can be a simple wrapper on current API
   
   other than this patch lgtm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services