You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by feidianbo <gi...@git.apache.org> on 2017/04/19 02:02:41 UTC
[GitHub] cordova-plugin-file-transfer pull request #177: fix Chinese words
GitHub user feidianbo opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
fix Chinese words
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/feidianbo/cordova-plugin-file-transfer patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit 1992cf452ac9a51233008cbc645b18d794861a0d
Author: DEO <f....@163.com>
Date: 2017-04-19T02:01:44Z
fix Chinese words
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename
Posted by feidianbo <gi...@git.apache.org>.
Github user feidianbo commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
@purplecabbage You can download the fowling image to check the bug:
http://git.oschina.net/fdb/demo1/raw/master/风景图片.jpg
The above url contains the Chinese words.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename
Posted by Better-Jiao <gi...@git.apache.org>.
Github user Better-Jiao commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
I get the same question and i had solve it. The code `NSString* filePath = [source hasPrefix:@"/"] ? [source copy] : [(NSURL *)[NSURL URLWithString:source] path];` in function `- (void)fileDataForUploadCommand:(CDVInvokedUrlCommand*)command` , if the file path include chinese , the `filePath` will return nil , so the `source` should be encode by utf-8.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
I think we should try to write a test for this, if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
@feidianbo Can you provide an example url that would have failed and now will pass, short of writing the whole test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/177/commits/1992cf452ac9a51233008cbc645b18d794861a0d)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/74/)
312 tests run, 15 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org