You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/05 08:48:48 UTC
[GitHub] [skywalking] dmsolr commented on a change in pull request #4006:
[test/plugin] immigrate test oracle scenario.
dmsolr commented on a change in pull request #4006: [test/plugin] immigrate test oracle scenario.
URL: https://github.com/apache/skywalking/pull/4006#discussion_r354173074
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -465,8 +465,16 @@ jobs:
java-version: 8
- name: Build SkyWalking Agent
run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+ - name: Download apm-oracle-10.x-plugin-1.0.1.jar to agent plugins dir.
Review comment:
we can configure multi-command with `run:.`
I suggest,
```
- name: Run oracle 10.2.0.4.0 (1)
run: |
curl -L -o ...
curl -L -o ...
./mvnw ...
./mvnw ...
bash ....
```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services