You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2017/11/27 20:16:11 UTC
Review Request 64097: SENTRY-2072: log4j2 dependencies brought by
Hive 2 are causing conflicts with Sentry log4j
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64097/
-----------------------------------------------------------
Review request for sentry and Sergio Pena.
Bugs: SENTRY-2072
https://issues.apache.org/jira/browse/SENTRY-2072
Repository: sentry
Description
-------
Added code changes to excude the log4j2 dependencies comming from hive-common, hive-exec, hive-metastore and hive-shims artifacts
Diffs
-----
pom.xml 3aedd3b
Diff: https://reviews.apache.org/r/64097/diff/1/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 64097: SENTRY-2072: log4j2 dependencies brought by
Hive 2 are causing conflicts with Sentry log4j
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64097/#review191933
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Nov. 27, 2017, 8:16 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64097/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 8:16 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-2072
> https://issues.apache.org/jira/browse/SENTRY-2072
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to excude the log4j2 dependencies comming from hive-common, hive-exec, hive-metastore and hive-shims artifacts
>
>
> Diffs
> -----
>
> pom.xml 3aedd3b
>
>
> Diff: https://reviews.apache.org/r/64097/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 64097: SENTRY-2072: log4j2 dependencies brought by
Hive 2 are causing conflicts with Sentry log4j
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64097/#review191930
-----------------------------------------------------------
Ship it!
I tested this patch in a cluster environment and the log is seen correctly now.
- Sergio Pena
On Nov. 27, 2017, 8:16 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64097/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 8:16 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-2072
> https://issues.apache.org/jira/browse/SENTRY-2072
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to excude the log4j2 dependencies comming from hive-common, hive-exec, hive-metastore and hive-shims artifacts
>
>
> Diffs
> -----
>
> pom.xml 3aedd3b
>
>
> Diff: https://reviews.apache.org/r/64097/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 64097: SENTRY-2072: log4j2 dependencies brought by
Hive 2 are causing conflicts with Sentry log4j
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64097/#review191954
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Nov. 27, 2017, 11:22 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64097/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 11:22 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-2072
> https://issues.apache.org/jira/browse/SENTRY-2072
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to excude the log4j2 dependencies comming from hive-common, hive-exec, hive-metastore and hive-shims artifacts
>
>
> Diffs
> -----
>
> pom.xml 3aedd3b38b067f9d32bf5ad1792bbb3df1378cf7
> sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html 9f52a8ea16cf9b89aff2e34851e4a3a198f88781
> sentry-tests/sentry-tests-hive/pom.xml da1d6980b76ec22d6e87889e3668bdfe498053e4
>
>
> Diff: https://reviews.apache.org/r/64097/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 64097: SENTRY-2072: log4j2 dependencies brought by
Hive 2 are causing conflicts with Sentry log4j
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64097/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 11:22 p.m.)
Review request for sentry and Sergio Pena.
Changes
-------
Updated the patch as the earlier one had hive test failures as hive server failed to start. It needed one of the jars that we excluded. I added a test dependency for log4j-core artifact.
Bugs: SENTRY-2072
https://issues.apache.org/jira/browse/SENTRY-2072
Repository: sentry
Description
-------
Added code changes to excude the log4j2 dependencies comming from hive-common, hive-exec, hive-metastore and hive-shims artifacts
Diffs (updated)
-----
pom.xml 3aedd3b38b067f9d32bf5ad1792bbb3df1378cf7
sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html 9f52a8ea16cf9b89aff2e34851e4a3a198f88781
sentry-tests/sentry-tests-hive/pom.xml da1d6980b76ec22d6e87889e3668bdfe498053e4
Diff: https://reviews.apache.org/r/64097/diff/2/
Changes: https://reviews.apache.org/r/64097/diff/1-2/
Testing
-------
Thanks,
kalyan kumar kalvagadda