You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/01/06 21:33:05 UTC
Review Request 16668: Adding java code coverage reporting into Aurora build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16668/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
-------
Adding code coverage report generation.
Diffs
-----
build.gradle 7cc1161d6d9cf1cced1ba7b7f7411db1698d7517
Diff: https://reviews.apache.org/r/16668/diff/
Testing
-------
$ gradle build
make: Nothing to be done for `all'.
:about
:bootstrapThrift UP-TO-DATE
:generateSources UP-TO-DATE
:compileGeneratedJava UP-TO-DATE
:processGeneratedResources UP-TO-DATE
:generatedClasses UP-TO-DATE
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar
:assemble
:checkstyleMain UP-TO-DATE
:compileTestJava
:processTestResources UP-TO-DATE
:testClasses
:checkstyleTest
:test
:jacocoTestReport
Coverage report generated: file:////Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html
:check
:build
BUILD SUCCESSFUL
Total time: 30.771 secs
File Attachments
----------------
Report.tiff
https://reviews.apache.org/media/uploaded/files/2014/01/06/1a11f81b-1535-4c51-a6e4-96ffc9ae5480__Report.tiff
Code.tiff
https://reviews.apache.org/media/uploaded/files/2014/01/06/2e1da342-9a1d-48b2-9b48-664760af8518__Code.tiff
Thanks,
Maxim Khutornenko
Re: Review Request 16668: Adding java code coverage reporting into Aurora
build.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16668/#review31260
-----------------------------------------------------------
Ship it!
I had to pause a bit since this tool is new to me, while i have experience with emma and cobertura. Useful context for others unfamiliar with jacoco:
"JaCoCo is an open source toolkit for measuring and reporting Java code coverage. JaCoCo is distributed under the terms of Eclipse Public License. It was developed as a replacement for EMMA[1] under the umbrella of the EclEmma eclipse project, and is currently the only byte code coverage tool working with Java 7.[2]"
http://en.wikipedia.org/wiki/Java_Code_Coverage_Tools#JaCoCo
- Bill Farner
On Jan. 6, 2014, 8:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16668/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 8:33 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding code coverage report generation.
>
>
> Diffs
> -----
>
> build.gradle 7cc1161d6d9cf1cced1ba7b7f7411db1698d7517
>
> Diff: https://reviews.apache.org/r/16668/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :about
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar
> :assemble
> :checkstyleMain UP-TO-DATE
> :compileTestJava
> :processTestResources UP-TO-DATE
> :testClasses
> :checkstyleTest
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
>
> BUILD SUCCESSFUL
>
> Total time: 30.771 secs
>
>
> File Attachments
> ----------------
>
> Report.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/1a11f81b-1535-4c51-a6e4-96ffc9ae5480__Report.tiff
> Code.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/2e1da342-9a1d-48b2-9b48-664760af8518__Code.tiff
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16668: Adding java code coverage reporting into Aurora
build.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16668/#review31261
-----------------------------------------------------------
Ship it!
Thanks for the context Bill!
- Kevin Sweeney
On Jan. 6, 2014, 12:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16668/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 12:33 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding code coverage report generation.
>
>
> Diffs
> -----
>
> build.gradle 7cc1161d6d9cf1cced1ba7b7f7411db1698d7517
>
> Diff: https://reviews.apache.org/r/16668/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :about
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar
> :assemble
> :checkstyleMain UP-TO-DATE
> :compileTestJava
> :processTestResources UP-TO-DATE
> :testClasses
> :checkstyleTest
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
>
> BUILD SUCCESSFUL
>
> Total time: 30.771 secs
>
>
> File Attachments
> ----------------
>
> Report.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/1a11f81b-1535-4c51-a6e4-96ffc9ae5480__Report.tiff
> Code.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/2e1da342-9a1d-48b2-9b48-664760af8518__Code.tiff
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16668: Adding java code coverage reporting into Aurora
build.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16668/#review31263
-----------------------------------------------------------
Thanks. Submitted.
- Maxim Khutornenko
On Jan. 6, 2014, 8:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16668/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 8:33 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding code coverage report generation.
>
>
> Diffs
> -----
>
> build.gradle 7cc1161d6d9cf1cced1ba7b7f7411db1698d7517
>
> Diff: https://reviews.apache.org/r/16668/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :about
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar
> :assemble
> :checkstyleMain UP-TO-DATE
> :compileTestJava
> :processTestResources UP-TO-DATE
> :testClasses
> :checkstyleTest
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
>
> BUILD SUCCESSFUL
>
> Total time: 30.771 secs
>
>
> File Attachments
> ----------------
>
> Report.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/1a11f81b-1535-4c51-a6e4-96ffc9ae5480__Report.tiff
> Code.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/2e1da342-9a1d-48b2-9b48-664760af8518__Code.tiff
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16668: Adding java code coverage reporting into Aurora
build.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16668/#review31259
-----------------------------------------------------------
Ship it!
looks good
- Jake Farrell
On Jan. 6, 2014, 8:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16668/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 8:33 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding code coverage report generation.
>
>
> Diffs
> -----
>
> build.gradle 7cc1161d6d9cf1cced1ba7b7f7411db1698d7517
>
> Diff: https://reviews.apache.org/r/16668/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :about
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar
> :assemble
> :checkstyleMain UP-TO-DATE
> :compileTestJava
> :processTestResources UP-TO-DATE
> :testClasses
> :checkstyleTest
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
>
> BUILD SUCCESSFUL
>
> Total time: 30.771 secs
>
>
> File Attachments
> ----------------
>
> Report.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/1a11f81b-1535-4c51-a6e4-96ffc9ae5480__Report.tiff
> Code.tiff
> https://reviews.apache.org/media/uploaded/files/2014/01/06/2e1da342-9a1d-48b2-9b48-664760af8518__Code.tiff
>
>
> Thanks,
>
> Maxim Khutornenko
>
>