You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/13 00:01:45 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #137: [YUNIKORN-224] False alarm in the log while removing a pod from scheduler cache

yangwwei opened a new pull request #137:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/137


   This is a false alarm, we do not need to throw an error when node is not found while removing a pod, just like: https://github.com/kubernetes/kubernetes/blob/2402bfd4bc329ae755250f5214351b1408a48eab/pkg/scheduler/internal/cache/cache.go#L446.
   
   This is just like what commented here:
   ```
   // Removes a pod from the cached node info. When a node is removed, some pod
   // deletion events might arrive later. This is not a problem, as the pods in
   // the node are assumed to be removed already.
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov-commenter commented on pull request #137: [YUNIKORN-224] False alarm in the log while removing a pod from scheduler cache

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #137:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/137#issuecomment-643530624


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=h1) Report
   > Merging [#137](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/82fb5a3bef6a059d65bb87cc39f6cf922f456fc8&el=desc) will **decrease** coverage by `0.19%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #137      +/-   ##
   ==========================================
   - Coverage   53.26%   53.06%   -0.20%     
   ==========================================
     Files          32       32              
     Lines        3030     3030              
   ==========================================
   - Hits         1614     1608       -6     
   - Misses       1355     1359       +4     
   - Partials       61       63       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/external/scheduler\_cache.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2V4dGVybmFsL3NjaGVkdWxlcl9jYWNoZS5nbw==) | `34.21% <0.00%> (ø)` | |
   | [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `54.83% <0.00%> (-9.68%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=footer). Last update [82fb5a3...a7478fe](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #137: [YUNIKORN-224] False alarm in the log while removing a pod from scheduler cache

Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #137:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/137


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org