You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Zoltan Kiss (JIRA)" <my...@incubator.apache.org> on 2005/08/29 13:08:05 UTC

[jira] Created: (MYFACES-456) enabledOnUserRole attribute malfunction

enabledOnUserRole attribute malfunction
---------------------------------------

         Key: MYFACES-456
         URL: http://issues.apache.org/jira/browse/MYFACES-456
     Project: MyFaces
        Type: Bug
  Components: Tomahawk  
    Versions: Nightly Build    
 Environment: any
 Reporter: Zoltan Kiss


The enabledOnUserRole attribute of the tags in the the http://myfaces.apache.org/extensions taglib is not working properly. If I use this attribute with a role which is not assigned with the  current logged in user, the component will be enabled, and not diasabled.

As I see the problem is, that all class in the org.apache.myfaces.renderkit.html.ext which have isDisabled function is returning false where they should return true.
Eg. the current code is:
    protected boolean isDisabled(FacesContext facesContext, UIComponent uiComponent) {
        if ( ! UserRoleUtils.isEnabledOnUserRole(uiComponent) ) {
            return false;
        }  else {
            return super.isDisabled(facesContext, uiComponent);
        }
    }
 
But it sould be 'return true;'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MYFACES-456) enabledOnUserRole attribute malfunction

Posted by "Bruno Aranda (JIRA)" <my...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-456?page=all ]
     
Bruno Aranda closed MYFACES-456:
--------------------------------

    Fix Version: Nightly Build
     Resolution: Fixed

This should be fixed in the next nightly build. Thanks for reporting and providing the solution!

> enabledOnUserRole attribute malfunction
> ---------------------------------------
>
>          Key: MYFACES-456
>          URL: http://issues.apache.org/jira/browse/MYFACES-456
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.0.10m10
>  Environment: any
>     Reporter: Zoltan Kiss
>      Fix For: Nightly Build

>
> The enabledOnUserRole attribute of the tags in the the http://myfaces.apache.org/extensions taglib is not working properly. If I use this attribute with a role which is not assigned with the  current logged in user, the component will be enabled, and not diasabled.
> As I see the problem is, that all class in the org.apache.myfaces.renderkit.html.ext which have isDisabled function is returning false where they should return true.
> Eg. the current code is:
>     protected boolean isDisabled(FacesContext facesContext, UIComponent uiComponent) {
>         if ( ! UserRoleUtils.isEnabledOnUserRole(uiComponent) ) {
>             return false;
>         }  else {
>             return super.isDisabled(facesContext, uiComponent);
>         }
>     }
>  
> But it sould be 'return true;'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira