[GitHub] [kafka] guozhangwang commented on a change in pull request #10612: KAFKA-10847: Add internal flag to disable KAFKA-10847 fix

[GitBox <gi...@apache.org>]

guozhangwang commented on a change in pull request #10612:
URL: https://github.com/apache/kafka/pull/10612#discussion_r624078706



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java
##########
@@ -95,7 +98,10 @@ public void writeToTopology(final InternalTopologyBuilder topologyBuilder) {
         topologyBuilder.addStateStore(thisWindowStoreBuilder, thisWindowedStreamProcessorName, otherProcessorName);
         topologyBuilder.addStateStore(otherWindowStoreBuilder, otherWindowedStreamProcessorName, thisProcessorName);
 
-        outerJoinWindowStoreBuilder.ifPresent(builder -> topologyBuilder.addStateStore(builder, thisProcessorName, otherProcessorName));
+        final StreamsConfig streamsConfig = topologyBuilder.getStreamsConfig();
+        if (streamsConfig == null || StreamsConfig.InternalConfig.getBoolean(streamsConfig.originals(), ENABLE_KSTREAMS_OUTER_JOIN_SPURIOUS_RESULTS_FIX, true)) {

Review comment:
       Do we expect the user of this internal flag to always set it? If say the caller had a bug to forget set it, should we default it to false instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org