[GitHub] [spark] huaxingao commented on a diff in pull request #36877: [SPARK-39479][SQL] DS V2 supports push down math functions(non ANSI)

[GitBox <gi...@apache.org>]

huaxingao commented on code in PR #36877:
URL: https://github.com/apache/spark/pull/36877#discussion_r898685809


##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -542,6 +544,60 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
         }
         checkPushedInfo(df8, expectedPlanFragment8)
         checkAnswer(df8, Seq(Row(2, "david", 10000, 1300, true)))
+
+        val df9 = spark.table("h2.test.employee")
+          .filter(logarithm(2, $"dept") > 2)
+          .filter(log10($"dept") > 0.5)
+          .filter(round($"dept") > 1)
+          .filter(degrees($"dept") > 100)
+          .filter(radians($"dept") > 0.1)
+          .filter(signum($"dept") === 1)
+        checkFiltersRemoved(df9, ansiMode)

Review Comment:
   These are not ansi functions, so the push down shouldn't be affected by `ansiMode`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org