You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/20 17:05:57 UTC

[GitHub] [iceberg] cccs-eric commented on a change in pull request #3940: Python: Fix type for partition_type struct fields (#3939)

cccs-eric commented on a change in pull request #3940:
URL: https://github.com/apache/iceberg/pull/3940#discussion_r788971760



##########
File path: python_legacy/iceberg/api/partition_spec.py
##########
@@ -76,7 +76,7 @@ def partition_type(self):
             result_type = field.transform.get_result_type(source_type)
             struct_fields.append(NestedField.optional(field.field_id,
                                                       field.name,
-                                                      result_type))
+                                                      result_type.get()))

Review comment:
       I'll admit that I thought all types had a `get()` method...  I only tested it with my use-case, which had a StringType.  I don't mind turning my PR into a bigger fix, but I'll wait for your advice 😄 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org