You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/04 12:53:49 UTC
[GitHub] [activemq-artemis] andytaylor opened a new pull request #3167: ARTEMIS-2793 - Only log quorum voting occurred when it actually does …
andytaylor opened a new pull request #3167:
URL: https://github.com/apache/activemq-artemis/pull/3167
…happen
https://issues.apache.org/jira/browse/ARTEMIS-2793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic closed pull request #3167: ARTEMIS-2793 - Only log quorum voting occurred when it actually does …
Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3167:
URL: https://github.com/apache/activemq-artemis/pull/3167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3167: ARTEMIS-2793 - Only log quorum voting occurred when it actually does …
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3167:
URL: https://github.com/apache/activemq-artemis/pull/3167#issuecomment-638829388
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3167: ARTEMIS-2793 - Only log quorum voting occurred when it actually does …
Posted by GitBox <gi...@apache.org>.
franz1981 commented on a change in pull request #3167:
URL: https://github.com/apache/activemq-artemis/pull/3167#discussion_r435263280
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumVoteServerConnect.java
##########
@@ -141,7 +141,11 @@ public synchronized Boolean getDecision() {
return votesNeeded == 0;
}
- public void await(int latchTimeout, TimeUnit unit) throws InterruptedException {
+ public void await(int latchTimeout, TimeUnit unit, int maxClusterSize) throws InterruptedException {
Review comment:
IMO this check should be moved into `QuorumManager`, given that:
- `maxClusterSize` is already owned and managed by it
- QuorumVoteServerConnect isn't aware of how many cluster members could perform the vote, just the expected number to unblock the quorum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3167: ARTEMIS-2793 - Only log quorum voting occurred when it actually does …
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3167:
URL: https://github.com/apache/activemq-artemis/pull/3167#issuecomment-639550699
@andytaylor my understanding this needs to be closed.
For some reason I have authorizatin to close it.. so I'm doing.. if you need any other chnages.. please reopen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org