You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 02:07:59 UTC
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #106: fix: tls remove failed & Add a node placeholder when the num of nodes…
codecov-io edited a comment on pull request #106:
URL: https://github.com/apache/apisix-ingress-controller/pull/106#issuecomment-747466476
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=h1) Report
> Merging [#106](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=desc) (9ceb452) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/983dbb02105d450ac74cf8da48f7c457f2c78d26?el=desc) (983dbb0) will **increase** coverage by `0.79%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 59.73% 60.53% +0.79%
==========================================
Files 16 16
Lines 524 527 +3
==========================================
+ Hits 313 319 +6
+ Misses 187 184 -3
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | `92.00% <100.00%> (+1.09%)` | :arrow_up: |
| [pkg/ingress/apisix/annotation.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L2Fubm90YXRpb24uZ28=) | `30.43% <0.00%> (+13.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=footer). Last update [983dbb0...9ceb452](https://codecov.io/gh/apache/apisix-ingress-controller/pull/106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org