You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2024/08/28 10:26:34 UTC
Re: [PR] [Improvement]: Merge amoro-core and amoro-ams/amoro-ams-api into one module amoro-common [amoro]
codecov-commenter commented on PR #3134:
URL: https://github.com/apache/amoro/pull/3134#issuecomment-2314930862
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3134?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `59.34066%` with `74 lines` in your changes missing coverage. Please review.
> Project coverage is 29.09%. Comparing base [(`bb91469`)](https://app.codecov.io/gh/apache/amoro/commit/bb9146927bb614ea9e42b2e6c52c409cb509a9a5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3b1a551`)](https://app.codecov.io/gh/apache/amoro/commit/3b1a5519615e3d98a0d0596de574bd0f9decf62c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/amoro/pull/3134?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/amoro/config/DataExpirationConfig.java](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&filepath=amoro-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fconfig%2FDataExpirationConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9hbW9yby9jb25maWcvRGF0YUV4cGlyYXRpb25Db25maWcuamF2YQ==) | 0.00% | [44 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/amoro/server/table/TableConfigurations.java](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&filepath=amoro-ams%2Famoro-ams-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2Ftable%2FTableConfigurations.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL2Ftb3JvLWFtcy1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Ftb3JvL3NlcnZlci90YWJsZS9UYWJsZUNvbmZpZ3VyYXRpb25zLmphdmE=) | 80.00% | [21 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/amoro/server/AmsServiceMetrics.java](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&filepath=amoro-ams%2Famoro-ams-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2FAmsServiceMetrics.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL2Ftb3JvLWFtcy1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Ftb3JvL3NlcnZlci9BbXNTZXJ2aWNlTWV0cmljcy5qYXZh) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...er/optimizing/maintainer/MixedTableMaintainer.java](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&filepath=amoro-ams%2Famoro-ams-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2Foptimizing%2Fmaintainer%2FMixedTableMaintainer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL2Ftb3JvLWFtcy1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Ftb3JvL3NlcnZlci9vcHRpbWl6aW5nL21haW50YWluZXIvTWl4ZWRUYWJsZU1haW50YWluZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../optimizing/maintainer/IcebergTableMaintainer.java](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&filepath=amoro-ams%2Famoro-ams-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2Foptimizing%2Fmaintainer%2FIcebergTableMaintainer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL2Ftb3JvLWFtcy1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Ftb3JvL3NlcnZlci9vcHRpbWl6aW5nL21haW50YWluZXIvSWNlYmVyZ1RhYmxlTWFpbnRhaW5lci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3134 +/- ##
============================================
+ Coverage 22.38% 29.09% +6.70%
- Complexity 2283 3646 +1363
============================================
Files 379 567 +188
Lines 38184 47025 +8841
Branches 5458 6193 +735
============================================
+ Hits 8549 13683 +5134
- Misses 28898 32363 +3465
- Partials 737 979 +242
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/3134/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core](https://app.codecov.io/gh/apache/amoro/pull/3134/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.09% <59.34%> (?)` | |
| [trino](https://app.codecov.io/gh/apache/amoro/pull/3134/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3134?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org