You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/02 10:34:00 UTC

[jira] [Commented] (FLINK-7728) StatusWatermarkValve has different min watermark advancement behavior depending on the ordering inputs become idle

    [ https://issues.apache.org/jira/browse/FLINK-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187842#comment-16187842 ] 

ASF GitHub Bot commented on FLINK-7728:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4747
  
    This looks very good, the test is also much cleaner and understandable now. 👌 
    
    One thing, in the refactoring the bit of testing code that verifies the fix for FLINK-7721 was dropped (I checked this by commenting out the fix in the code). I'll re-add a test for that and merge.


> StatusWatermarkValve has different min watermark advancement behavior depending on the ordering inputs become idle
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7728
>                 URL: https://issues.apache.org/jira/browse/FLINK-7728
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.2.1, 1.4.0, 1.3.2
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.2.2, 1.4.0, 1.3.3
>
>
> Currently, once all inputs of a {{StatusWatermarkValve}} becomes idle, we only emit the {{StreamStatus.IDLE}} marker, and check nothing else. This makes the watermark advancement behavior inconsistent in the case that all inputs become idle, depending on the order that they become idle.
> Consider the following setup:
> {code}
> Channel #1: Watermark 10, ACTIVE
> Channel #2: Watermark 5, ACTIVE
> Channel #3: Watermark 5, ACTIVE
> {code}
> If the channels become IDLE with the order #2 -> #3 -> #1, watermark 10 will be emitted as the new min watermark once both #2 and #3 becomes idle.
> On the other hand, if the order is #1 -> #2 -> #3, watermark 10 will not be emitted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)