You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/29 01:09:55 UTC

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17880: [improve][broker] Add URL check when add/update cluster.

codelipenghui commented on code in PR #17880:
URL: https://github.com/apache/pulsar/pull/17880#discussion_r982977676


##########
pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java:
##########
@@ -106,7 +106,14 @@ public static ServiceURI create(String uriStr) {
 
         return create(uri);
     }
-
+    public static void validate(String urlStr) {

Review Comment:
   I think we should
   
   The service URL can only start with pulsar or pulsar+ssl
   The web service URL can only start with http or https



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org