Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

[David Radley <da...@uk.ibm.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60578/#review179471
-----------------------------------------------------------




addons/models/0030-hive_model.json
Lines 551 (patched)
<https://reviews.apache.org/r/60578/#comment254185>

    I am unsure how this is working. We have columns defined in the old style with constraints and we have them defined in the new style. I was not expecting 2 definitions for columns. Isn't this going to show in the graph as the old style EntityDef vertices and edges and the new style relationshipDef and edges.


- David Radley


On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60578/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 8:25 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1907
>     https://issues.apache.org/jira/browse/ATLAS-1907
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Create relationshipDefs for all out of the box models. Use relationshipDef information when creating edges for composite attributes in entities.
> 
> 
> Diffs
> -----
> 
>   addons/models/0010-base_model.json 7f64d85e 
>   addons/models/0030-hive_model.json b359ea82 
>   addons/models/0050-falcon_model.json b7398ef4 
>   addons/models/0060-hbase_model.json 42fe00c4 
>   addons/models/0080-storm_model.json 095936e0 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e3 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 8d2e7ec5 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 70e3067a 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35c 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c2e0be50 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 29fae1c8 
>   repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 4530f51b 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 5ea4ff20 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 7b3f1e6e 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 86212338 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java ebf6a201 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60578/diff/1/
> 
> 
> Testing
> -------
> 
> Tested using Postman REST client.
> Validated all hive_table creation works fine and lineage is rendered right.
> 
> UTs/ITs in progress.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>