[GitHub] [airflow] ephraimbuddy commented on pull request #22756: Add more fields to REST API dags/dag_id/details endpoint

[GitBox <gi...@apache.org>]

ephraimbuddy commented on PR #22756:
URL: https://github.com/apache/airflow/pull/22756#issuecomment-1091446319

   > Many of those properties are internal detail of how things are stored/implemented and I'm not sure it make senses to include them in the output.
   > 
   > Specifically:
   > 
   > * edge_info this feels out of place on the DAG details endpoint (and is just an implementation detail of how we store edge labels) but maybe this is the only place it makes sense to include. If we want to keep this here we should specify the type more tightly than just "object"
   > * partial will never be True on a dag returned by the API. Remove
   > * has_*_callback is an artefact of serialization. Remove?
   > * user_defined_* -- what value does this even have when those are set? What could an API consumer do with that info. Remove?
   > * default_args: is this relevant to anything?
   > * jinja_environment_kwargs: Remove?
   > * render_template_as_native_obj: Relevant? Remove?
   
   Looks like we don't really need to add more to what is already existing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org