You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by clems4ever <gi...@git.apache.org> on 2018/04/17 21:14:01 UTC

[GitHub] mesos pull request #284: Remove accent from first name of clems4ever contrib...

GitHub user clems4ever opened a pull request:

    https://github.com/apache/mesos/pull/284

    Remove accent from first name of clems4ever contributor.

    Review bot fails to apply reviews (with ./support/apply-review.py script) because of the accent in my first name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clems4ever/mesos clems4ever-contributor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mesos/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #284
    
----
commit 9751c6eacbedca7e48e595f5d0a97eb0981748f4
Author: Clement Michaud <cl...@...>
Date:   2018-04-17T21:11:10Z

    Remove accent from first name of clems4ever contributor.

----


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by kaysoky <gi...@git.apache.org>.

Github user kaysoky commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    Here's the associated JIRA: https://issues.apache.org/jira/browse/MESOS-7658


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by andschwa <gi...@git.apache.org>.

Github user andschwa commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    @bmahler Really the only fix is to convert our Python scripts to Python 3. (I tried to get someone at the Hackathon to do this 😉 but failed 😦).


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by gkleiman <gi...@git.apache.org>.

Github user gkleiman commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    I also had to change my name from `Gastón` to `Gaston` to stop the Windows reviewbot from failing to apply my patches.


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by clems4ever <gi...@git.apache.org>.

Github user clems4ever commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    Hello @tillt , there is an issue with the review bot applying my review: https://reviews.apache.org/r/66621/. I think it is due to the accent in my first name.
    So, I created this review to remove the accent. Can you please merge it? Thanks.


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by clems4ever <gi...@git.apache.org>.

Github user clems4ever commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    @andschwa , no problem. Do you have the rights to merge it?


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by bmahler <gi...@git.apache.org>.

Github user bmahler commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    @clems4ever can you post the error? Is this an issue in `rbt` or our python wrapper script?


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by bbannier <gi...@git.apache.org>.

Github user bbannier commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    @clems4ever I don't believe fixing that database is going to make `support/apply_reviews.py` work. I think you need to reconfigure the name you use to create git commit you put onto reviewboard -- this can be done for just the Mesos repo with `git config user name ...`.
    
    Sorry for the inconvenience :/


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by bmahler <gi...@git.apache.org>.

Github user bmahler commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    We should try to fix apply-reviews.py. Looks related to this discussion?
    https://bugs.python.org/issue1759845


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by clems4ever <gi...@git.apache.org>.

Github user clems4ever commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    @bbannier , apparently apply-review.py retrieves data from the profile in the review board. I updated my profile and now the author is correct (I mean without accent).
    Thank you for the help.


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by clems4ever <gi...@git.apache.org>.

Github user clems4ever commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    @bmahler , here is the error:


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

Posted by clems4ever <gi...@git.apache.org>.

Github user clems4ever commented on the issue:

    https://github.com/apache/mesos/pull/284
  
    Thank you guys for your feedbacks. Since it might take some time to rewrite the script in Python 3 I think it's better to merge this PR so that I can move forward with my review in the review board. What do you think?


---